* [linux-firmware] Version in WHENCE file
@ 2018-05-06 12:46 Sedat Dilek
2018-05-06 13:07 ` Luciano Coelho
0 siblings, 1 reply; 4+ messages in thread
From: Sedat Dilek @ 2018-05-06 12:46 UTC (permalink / raw)
To: Luca Coelho; +Cc: linux-wireless, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
Hi Luca,
I hope I catched the correct MLs (not sure if linux-firmware has a ML,
I did not found any in the MAINTAINERS file).
I have seen that in the WHENCE file there is "Version" with and
without ":", mostly iwlwifi ucodes.
As an example:
File: iwlwifi-8265-36.ucode
-Version 36.e91976c0.0
+Version: 36.e91976c0.0
I don't know the workflow: Do you want to fix it in your tree or
directly in linux-firmware.git upstream?
My attached patch is against upstream.
Thanks.
Regards,
- Sedat -
[1] https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware.git/commit/?id=1f4dbd8cb94ec37497e58627a127058d53c5968f
[-- Attachment #2: 0001-WHENCE-Fix-typo-Version.patch --]
[-- Type: text/x-patch, Size: 3172 bytes --]
From 576d30ace8140ca7b5c8a276f67da1cb2ebfb0c2 Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.dilek@credativ.de>
Date: Sun, 6 May 2018 14:44:54 +0200
Subject: [PATCH] WHENCE: Fix typo Version
---
WHENCE | 58 +++++++++++++++++++++++++++++-----------------------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/WHENCE b/WHENCE
index 690a6a5d4149..ab915ee6b24f 100644
--- a/WHENCE
+++ b/WHENCE
@@ -866,10 +866,10 @@ File: iwlwifi-7260-13.ucode
Version: 25.30.13.0
File: iwlwifi-7260-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-7260-17.ucode
-Version 17.388f111f.0
+Version: 17.388f111f.0
File: iwlwifi-3160-7.ucode
Version: 22.1.7.0
@@ -890,10 +890,10 @@ File: iwlwifi-3160-13.ucode
Version: 25.30.13.0
File: iwlwifi-3160-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-3160-17.ucode
-Version 17.388f111f.0
+Version: 17.388f111f.0
File: iwlwifi-7265-8.ucode
Version: 22.24.8.0
@@ -911,10 +911,10 @@ File: iwlwifi-7265-13.ucode
Version: 25.30.13.0
File: iwlwifi-7265-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-7265-17.ucode
-Version 17.388f111f.0
+Version: 17.388f111f.0
File: iwlwifi-7265D-10.ucode
Version: 23.15.10.0
@@ -926,76 +926,76 @@ File: iwlwifi-7265D-13.ucode
Version: 25.30.13.0
File: iwlwifi-7265D-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-7265D-17.ucode
-Version 17.352738.0
+Version: 17.352738.0
File: iwlwifi-7265D-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-7265D-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-7265D-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-7265D-29.ucode
-Version 29.3e3b4de5.0
+Version: 29.3e3b4de5.0
File: iwlwifi-3168-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-3168-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-3168-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-3168-29.ucode
-Version 29.3e3b4de5.0
+Version: 29.3e3b4de5.0
File: iwlwifi-8000C-13.ucode
Version: 25.30.13.0
File: iwlwifi-8000C-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-8000C-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-8000C-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-8000C-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-8000C-31.ucode
-Version 31.560484.0
+Version: 31.560484.0
File: iwlwifi-8000C-34.ucode
-Version 34.610288.0
+Version: 34.610288.0
File: iwlwifi-8000C-36.ucode
-Version 36.e91976c0.0
+Version: 36.e91976c0.0
File: iwlwifi-8265-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-8265-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-8265-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-8265-31.ucode
-Version 31.560484.0
+Version: 31.560484.0
File: iwlwifi-8265-34.ucode
-Version 34.610288.0
+Version: 34.610288.0
File: iwlwifi-8265-36.ucode
-Version 36.e91976c0.0
+Version: 36.e91976c0.0
File: iwlwifi-9000-pu-b0-jf-b0-33.ucode
Version: 33.610294.0
--
2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux-firmware] Version in WHENCE file
2018-05-06 12:46 [linux-firmware] Version in WHENCE file Sedat Dilek
@ 2018-05-06 13:07 ` Luciano Coelho
2018-05-07 7:47 ` Sedat Dilek
0 siblings, 1 reply; 4+ messages in thread
From: Luciano Coelho @ 2018-05-06 13:07 UTC (permalink / raw)
To: sedat.dilek; +Cc: linux-wireless, linux-kernel
On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote:
> Hi Luca,
>
> I hope I catched the correct MLs (not sure if linux-firmware has a
> ML,
> I did not found any in the MAINTAINERS file).
>
> I have seen that in the WHENCE file there is "Version" with and
> without ":", mostly iwlwifi ucodes.
>
> As an example:
>
> File: iwlwifi-8265-36.ucode
> -Version 36.e91976c0.0
> +Version: 36.e91976c0.0
>
> I don't know the workflow: Do you want to fix it in your tree or
> directly in linux-firmware.git upstream?
> My attached patch is against upstream.
Thanks, Sedat!
I'm going to send a new pull-request this week, so I can include your
patch in my tree and as part of the pull-request.
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux-firmware] Version in WHENCE file
2018-05-06 13:07 ` Luciano Coelho
@ 2018-05-07 7:47 ` Sedat Dilek
2018-05-17 5:24 ` Luciano Coelho
0 siblings, 1 reply; 4+ messages in thread
From: Sedat Dilek @ 2018-05-07 7:47 UTC (permalink / raw)
To: Luciano Coelho; +Cc: linux-wireless, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
On Sun, May 6, 2018 at 3:07 PM, Luciano Coelho <luciano.coelho@intel.com> wrote:
> On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote:
>> Hi Luca,
>>
>> I hope I catched the correct MLs (not sure if linux-firmware has a
>> ML,
>> I did not found any in the MAINTAINERS file).
>>
>> I have seen that in the WHENCE file there is "Version" with and
>> without ":", mostly iwlwifi ucodes.
>>
>> As an example:
>>
>> File: iwlwifi-8265-36.ucode
>> -Version 36.e91976c0.0
>> +Version: 36.e91976c0.0
>>
>> I don't know the workflow: Do you want to fix it in your tree or
>> directly in linux-firmware.git upstream?
>> My attached patch is against upstream.
>
> Thanks, Sedat!
>
> I'm going to send a new pull-request this week, so I can include your
> patch in my tree and as part of the pull-request.
>
> --
> Cheers,
> Luca.
OK, Thanks.
Attached Patch v2 is against your tree [1].
It differs from v1 against upstream.
- Sedat -
[1] https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware.git/
[-- Attachment #2: 0001-WHENCE-Fix-typo-Version-v2.patch --]
[-- Type: text/x-patch, Size: 3085 bytes --]
From 6e3a597632ab38619383d27a23b7369121da6d1b Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.dilek@credativ.de>
Date: Mon, 7 May 2018 09:44:26 +0200
Subject: [PATCH] WHENCE: Fix typo Version v2
---
WHENCE | 56 ++++++++++++++++++++++++++++----------------------------
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/WHENCE b/WHENCE
index fe63439b8cad..3678bc41a0f0 100644
--- a/WHENCE
+++ b/WHENCE
@@ -866,10 +866,10 @@ File: iwlwifi-7260-13.ucode
Version: 25.30.13.0
File: iwlwifi-7260-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-7260-17.ucode
-Version 17.bfb58538.0
+Version: 17.bfb58538.0
File: iwlwifi-3160-7.ucode
Version: 22.1.7.0
@@ -890,10 +890,10 @@ File: iwlwifi-3160-13.ucode
Version: 25.30.13.0
File: iwlwifi-3160-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-3160-17.ucode
-Version 17.bfb58538.0
+Version: 17.bfb58538.0
File: iwlwifi-7265-8.ucode
Version: 22.24.8.0
@@ -911,10 +911,10 @@ File: iwlwifi-7265-13.ucode
Version: 25.30.13.0
File: iwlwifi-7265-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-7265-17.ucode
-Version 17.bfb58538.0
+Version: 17.bfb58538.0
File: iwlwifi-7265D-10.ucode
Version: 23.15.10.0
@@ -926,73 +926,73 @@ File: iwlwifi-7265D-13.ucode
Version: 25.30.13.0
File: iwlwifi-7265D-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-7265D-17.ucode
-Version 17.352738.0
+Version: 17.352738.0
File: iwlwifi-7265D-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-7265D-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-7265D-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-7265D-29.ucode
-Version 29.3e3b4de5.0
+Version: 29.3e3b4de5.0
File: iwlwifi-3168-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-3168-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-3168-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-3168-29.ucode
-Version 29.3e3b4de5.0
+Version: 29.3e3b4de5.0
File: iwlwifi-8000C-13.ucode
Version: 25.30.13.0
File: iwlwifi-8000C-16.ucode
-Version 16.242414.0
+Version: 16.242414.0
File: iwlwifi-8000C-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-8000C-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-8000C-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-8000C-31.ucode
-Version 31.560484.0
+Version: 31.560484.0
File: iwlwifi-8000C-34.ucode
-Version 34.610288.0
+Version: 34.610288.0
File: iwlwifi-8000C-36.ucode
-Version 36.7596afd4.0
+Version: 36.7596afd4.0
File: iwlwifi-8265-21.ucode
-Version 21.302800.0
+Version: 21.302800.0
File: iwlwifi-8265-22.ucode
-Version 22.391740.0
+Version: 22.391740.0
File: iwlwifi-8265-27.ucode
-Version 27.541033.0
+Version: 27.541033.0
File: iwlwifi-8265-31.ucode
-Version 31.560484.0
+Version: 31.560484.0
File: iwlwifi-8265-34.ucode
-Version 34.610288.0
+Version: 34.610288.0
File: iwlwifi-8265-36.ucode
Version: 36.7596afd4.0
--
2.17.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [linux-firmware] Version in WHENCE file
2018-05-07 7:47 ` Sedat Dilek
@ 2018-05-17 5:24 ` Luciano Coelho
0 siblings, 0 replies; 4+ messages in thread
From: Luciano Coelho @ 2018-05-17 5:24 UTC (permalink / raw)
To: sedat.dilek; +Cc: linux-wireless, linux-kernel
On Mon, 2018-05-07 at 09:47 +0200, Sedat Dilek wrote:
> On Sun, May 6, 2018 at 3:07 PM, Luciano Coelho <luciano.coelho@intel.
> com> wrote:
> > On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote:
> > > Hi Luca,
> > >
> > > I hope I catched the correct MLs (not sure if linux-firmware has
> > > a
> > > ML,
> > > I did not found any in the MAINTAINERS file).
> > >
> > > I have seen that in the WHENCE file there is "Version" with and
> > > without ":", mostly iwlwifi ucodes.
> > >
> > > As an example:
> > >
> > > File: iwlwifi-8265-36.ucode
> > > -Version 36.e91976c0.0
> > > +Version: 36.e91976c0.0
> > >
> > > I don't know the workflow: Do you want to fix it in your tree or
> > > directly in linux-firmware.git upstream?
> > > My attached patch is against upstream.
> >
> > Thanks, Sedat!
> >
> > I'm going to send a new pull-request this week, so I can include
> > your
> > patch in my tree and as part of the pull-request.
> >
> > --
> > Cheers,
> > Luca.
>
> OK, Thanks.
> Attached Patch v2 is against your tree [1].
> It differs from v1 against upstream.
You need to write a proper commit message and sign it off so I can
apply it.
--
Luca.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-17 5:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-06 12:46 [linux-firmware] Version in WHENCE file Sedat Dilek
2018-05-06 13:07 ` Luciano Coelho
2018-05-07 7:47 ` Sedat Dilek
2018-05-17 5:24 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®