From: Markus Elfring <Markus.Elfring@web.de>
To: kernel-janitors@vger.kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Marek Behún" <kabel@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Robin van der Gracht" <robin@protonic.nl>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] auxdisplay: ht16k33: Drop device node reference after registration failure in ht16k33_led_probe()
Date: Tue, 4 Jun 2024 17:15:37 +0200 [thread overview]
Message-ID: <0fc79fe9-da49-4cbe-a7ff-6443ad93f120@web.de> (raw)
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 4 Jun 2024 17:02:15 +0200
A failed call of the function “devm_led_classdev_register_ext”
can be reported.
Add a call of the function “fwnode_handle_put” for this error case.
Fixes: c223d9c636ed ("auxdisplay: ht16k33: Add LED support")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/auxdisplay/ht16k33.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index ce987944662c..ef86537c9d83 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -483,8 +483,10 @@ static int ht16k33_led_probe(struct device *dev, struct led_classdev *led,
led->max_brightness = MAX_BRIGHTNESS;
err = devm_led_classdev_register_ext(dev, led, &init_data);
- if (err)
+ if (err) {
dev_err(dev, "Failed to register LED\n");
+ fwnode_handle_put(init_data.fwnode);
+ }
return err;
}
--
2.45.1
next reply other threads:[~2024-06-04 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 15:15 Markus Elfring [this message]
2024-06-04 16:33 ` Andy Shevchenko
2024-06-04 18:15 ` Markus Elfring
2024-06-04 19:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fc79fe9-da49-4cbe-a7ff-6443ad93f120@web.de \
--to=markus.elfring@web.de \
--cc=andy@kernel.org \
--cc=geert@linux-m68k.org \
--cc=kabel@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome