From: Andy Shevchenko <andy@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: kernel-janitors@vger.kernel.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Marek Behún" <kabel@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Robin van der Gracht" <robin@protonic.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: auxdisplay: ht16k33: Drop device node reference after registration failure in ht16k33_led_probe()
Date: Tue, 4 Jun 2024 22:30:07 +0300 [thread overview]
Message-ID: <Zl9rPy3hD-Hk-gxm@smile.fi.intel.com> (raw)
In-Reply-To: <503de0cb-09d2-4716-99cb-de257a33bad8@web.de>
On Tue, Jun 04, 2024 at 08:15:35PM +0200, Markus Elfring wrote:
> > But, by design we don't use reference counting after we registered LED,
> > hence both error and successful paths need to have this,
>
> Do you indicate really special data processing constraints here?
Nothing special, either we hold reference for the entire life time of the
device or not. For LEDS the convention is not to hold.
> > so add another fwnode_handle_put() after this branch.
>
> Will this suggestion trigger any further clarifications for the affected software?
You need to put an fwnode handle in both paths: inside the if branch as you
have done (error path) and missing one is after that needs to be added.
Just address my comments and I believe everyone will be happy about it.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-06-04 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 15:15 [PATCH] " Markus Elfring
2024-06-04 16:33 ` Andy Shevchenko
2024-06-04 18:15 ` Markus Elfring
2024-06-04 19:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl9rPy3hD-Hk-gxm@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=geert@linux-m68k.org \
--cc=kabel@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®