mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Luca Stefani <luca.stefani.ge1@gmail.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
	Mark Gross <markgross@kernel.org>,
	"open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS" 
	<acpi4asus-user@lists.sourceforge.net>,
	"open list:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS" 
	<platform-driver-x86@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] platform/x86: asus-wmi: Update unknown code message
Date: Wed, 11 May 2022 17:16:33 +0200	[thread overview]
Message-ID: <0fd2b4d0-e219-2e47-dd39-f73076e1eb9a@redhat.com> (raw)
In-Reply-To: <20220506122536.113566-1-luca.stefani.ge1@gmail.com>

Hi,

On 5/6/22 14:25, Luca Stefani wrote:
> Prepend 0x to the actual key code to specify it
> is already an hex value
> 
> Signed-off-by: Luca Stefani <luca.stefani.ge1@gmail.com>

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans





> ---
>  drivers/platform/x86/asus-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index 0e7fbed8a50d..35fe9641ba9b 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -3114,7 +3114,7 @@ static void asus_wmi_handle_event_code(int code, struct asus_wmi *asus)
>  
>  	if (!sparse_keymap_report_event(asus->inputdev, code,
>  					key_value, autorelease))
> -		pr_info("Unknown key %x pressed\n", code);
> +		pr_info("Unknown key code 0x%x\n", code);
>  }
>  
>  static void asus_wmi_notify(u32 value, void *context)


      parent reply	other threads:[~2022-05-11 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 12:25 Luca Stefani
2022-05-06 12:25 ` [PATCH 2/2] platform/x86: asus-nb-wmi: Add keymap for MyASUS key Luca Stefani
2022-05-11 15:16 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fd2b4d0-e219-2e47-dd39-f73076e1eb9a@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.stefani.ge1@gmail.com \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®