mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@linux.alibaba.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Wanpeng Li <wanpeng.li@hotmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] cputime: remove rq parameter for irqtime_account_process_tick func
Date: Mon, 22 Jul 2019 15:37:55 +0800	[thread overview]
Message-ID: <0fdee790-638b-9228-9c85-b8fefa78b7f2@linux.alibaba.com> (raw)
In-Reply-To: <20190719081156.GE3419@hirez.programming.kicks-ass.net>



在 2019/7/19 下午4:11, Peter Zijlstra 写道:
> On Fri, Jul 19, 2019 at 10:42:41AM +0800, Alex Shi wrote:
>> Using the per cpu rq in function directly is enough, don't need get and
>> pass it from outside as a parameter. That's make function neat.
> 
> Please look at code-gen; I'm thinking this patch makes things worse.
> 

Thanks a lot, Peter! 

This patch reference one more time on this_rq(), that do increase cputime.o size. I will move it after access_process_tick() patch in v3. That could resovle the problem and decreases objfile's size on each of patches.

Thanks
Alex 

      reply	other threads:[~2019-07-22  7:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-19  2:42 Alex Shi
2019-07-19  2:42 ` [PATCH v2 2/2] cputime: remove duplicate code in account_process_tick Alex Shi
2019-07-19  8:11 ` [PATCH v2 1/2] cputime: remove rq parameter for irqtime_account_process_tick func Peter Zijlstra
2019-07-22  7:37   ` Alex Shi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0fdee790-638b-9228-9c85-b8fefa78b7f2@linux.alibaba.com \
    --to=alex.shi@linux.alibaba.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®