From: Peter Zijlstra <peterz@infradead.org>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Wanpeng Li <wanpeng.li@hotmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] cputime: remove rq parameter for irqtime_account_process_tick func
Date: Fri, 19 Jul 2019 10:11:56 +0200 [thread overview]
Message-ID: <20190719081156.GE3419@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190719024242.249429-1-alex.shi@linux.alibaba.com>
On Fri, Jul 19, 2019 at 10:42:41AM +0800, Alex Shi wrote:
> Using the per cpu rq in function directly is enough, don't need get and
> pass it from outside as a parameter. That's make function neat.
Please look at code-gen; I'm thinking this patch makes things worse.
next prev parent reply other threads:[~2019-07-19 8:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 2:42 Alex Shi
2019-07-19 2:42 ` [PATCH v2 2/2] cputime: remove duplicate code in account_process_tick Alex Shi
2019-07-19 8:11 ` Peter Zijlstra [this message]
2019-07-22 7:37 ` [PATCH v2 1/2] cputime: remove rq parameter for irqtime_account_process_tick func Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719081156.GE3419@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alex.shi@linux.alibaba.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome