From: Adam Young <admiyo@amperemail.onmicrosoft.com>
To: "lihuisong (C)" <lihuisong@huawei.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
admiyo@os.amperecomputing.com,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Eric Dumazet <edumazet@google.com>,
Matt Johnston <matt@codeconstruct.com.au>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v20 1/1] mctp pcc: Implement MCTP over PCC Transport
Date: Sun, 13 Jul 2025 19:50:43 -0400 [thread overview]
Message-ID: <0fe71acb-b8b5-4d30-93b4-21aedf2152c8@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <c2034f07-5422-4ab1-952e-f7d74d0675a7@huawei.com>
On 6/3/25 08:03, lihuisong (C) wrote:
>>
>> Once the memcpy_toio completes, the driver will not look at the
>> packet again. if the Kernel did change it at this point, it would
>> not affect the flow. The send of the packet is checked vi rc
>> returned from send_data, and it tags the packet as dropped. Is this
>> not sufficient?
>>
> Yes, it is not enough.
> Once send_data() return success, platform can receive an interrupt，but
> the processing of the platform has not ended.
> This processing includes handling data and then triggering an
> interrupt to notify OS.
This comment caused me to rethink how I was using the PCC mailbox API.
I realized that it was not actually enforcing the PCC protocol, which
you identified. It lead me to rewrite a postion of the PCC Mailbox API,
and that is in my next patch series. I would appreciate it if you would
take a look. I think it addresses this concern, but it might not be
completely transparent to a reviewer. I would greatly appreciate if
you were to look at it and confirm it fixes the issue, or, if I have
missed something, let me know what you see.
prev parent reply other threads:[~2025-07-13 23:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 22:01 [PATCH net-next v20 0/1] MCTP Over " admiyo
2025-04-23 22:01 ` [PATCH net-next v20 1/1] mctp pcc: Implement MCTP over " admiyo
2025-04-24 9:57 ` Jonathan Cameron
2025-04-28 18:57 ` Adam Young
2025-04-29 4:08 ` Jeremy Kerr
2025-04-24 13:03 ` lihuisong (C)
2025-04-28 18:48 ` Adam Young
2025-05-30 6:19 ` lihuisong (C)
2025-06-02 20:51 ` Adam Young
2025-06-03 12:03 ` lihuisong (C)
2025-07-13 23:50 ` Adam Young [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe71acb-b8b5-4d30-93b4-21aedf2152c8@amperemail.onmicrosoft.com \
--to=admiyo@amperemail.onmicrosoft.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®