From: Adam Young <admiyo@amperemail.onmicrosoft.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
admiyo@os.amperecomputing.com
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH net-next v20 1/1] mctp pcc: Implement MCTP over PCC Transport
Date: Mon, 28 Apr 2025 14:57:19 -0400 [thread overview]
Message-ID: <a12dee5c-2d59-4941-84b5-ae8bffcedd6c@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20250424105752.00007396@huawei.com>
On 4/24/25 05:57, Jonathan Cameron wrote:
>> +
>> + mctp_pcc_header = skb_push(skb, sizeof(struct mctp_pcc_hdr));
> I'd use sizeof(*mctp_pcc_header) for these to avoid the reader needing to check
> types. There are a bunch of these you could do the same with to slightly
> improve readability.
I get a compilation error when I try that:
drivers/net/mctp/mctp-pcc.c: In function ‘mctp_pcc_client_rx_callback’:
drivers/net/mctp/mctp-pcc.c:80:30: error: invalid type argument of unary
‘*’ (have ‘struct mctp_pcc_hdr’)
80 | sizeof(*mctp_pcc_hdr));
Maybe a compiler flag difference?
next prev parent reply other threads:[~2025-04-28 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 22:01 [PATCH net-next v20 0/1] MCTP Over " admiyo
2025-04-23 22:01 ` [PATCH net-next v20 1/1] mctp pcc: Implement MCTP over " admiyo
2025-04-24 9:57 ` Jonathan Cameron
2025-04-28 18:57 ` Adam Young [this message]
2025-04-29 4:08 ` Jeremy Kerr
2025-04-24 13:03 ` lihuisong (C)
2025-04-28 18:48 ` Adam Young
2025-05-30 6:19 ` lihuisong (C)
2025-06-02 20:51 ` Adam Young
2025-06-03 12:03 ` lihuisong (C)
2025-07-13 23:50 ` Adam Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a12dee5c-2d59-4941-84b5-ae8bffcedd6c@amperemail.onmicrosoft.com \
--to=admiyo@amperemail.onmicrosoft.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®