From: Mark Brown <broonie@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: "Rick P. Edgecombe" <rick.p.edgecombe@intel.com>,
Deepak Gupta <debug@rivosinc.com>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
"H.J. Lu" <hjl.tools@gmail.com>,
Florian Weimer <fweimer@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
jannh@google.com, Andrew Morton <akpm@linux-foundation.org>,
Yury Khrustalev <yury.khrustalev@arm.com>,
Wilco Dijkstra <wilco.dijkstra@arm.com>,
linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org,
Kees Cook <kees@kernel.org>
Subject: Re: [PATCH v20 4/8] fork: Add shadow stack support to clone3()
Date: Fri, 5 Sep 2025 16:43:22 +0100 [thread overview]
Message-ID: <0ff8b70e-283f-4d56-8bab-bcae11cd5bdb@sirena.org.uk> (raw)
In-Reply-To: <20250905-nutria-befund-2f3e92003734@brauner>
[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]
On Fri, Sep 05, 2025 at 05:21:59PM +0200, Christian Brauner wrote:
> On Tue, Sep 02, 2025 at 11:21:48AM +0100, Mark Brown wrote:
> > + .shadow_stack_token = args.shadow_stack_token,
> I'm not sure why this has to be named "shadow_stack_token" I think
> that's just confusing and we should just call it "shadow_stack" and be
> done with it. It's also a bit long of a field name imho.
I'm not hugely attached to the name, if you want to rename that's
perfectly fine by me. My thinking was that there's a potential
confusion with it being a pointer to the base of the shadow stack by
comparison with the existing "stack" but I do agree that the resulting
name is quite long and if someone does actually get confused they should
discover the problem fairly rapidly in testing. ss_token would shorter
but the abbreviation is less clear, whatever name you prefer is fine by
me.
> I have a kernel-6.18.clone3 branch
> https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/log/?h=kernel-6.18.clone3
> because there's another cross-arch cleanup that cleans up copy_thread(),
> copy_sighand(), and copy_process() and - surprisingly - also adds
> clone3() support for nios2...
> Anyway, if you just want me to slap it on top of that branch then I can
> simply rename while applying so no need to resend in that case.
That would be amazing, I'm totally happy with you doing that. If I do
need to rebase and resend let me know.
It's probably worth mentioning that the RISC-V shadow stack support was
getting near to being merged, if that ends up being OK for this release
(it's not been posted yet though) there might be some cross tree merge
needed or something.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-09-05 15:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 10:21 [PATCH v20 0/8] fork: Support shadow stacks in clone3() Mark Brown
2025-09-02 10:21 ` [PATCH v20 1/8] arm64/gcs: Return a success value from gcs_alloc_thread_stack() Mark Brown
2025-09-02 10:21 ` [PATCH v20 2/8] Documentation: userspace-api: Add shadow stack API documentation Mark Brown
2025-09-02 10:21 ` [PATCH v20 3/8] selftests: Provide helper header for shadow stack testing Mark Brown
2025-09-02 10:21 ` [PATCH v20 4/8] fork: Add shadow stack support to clone3() Mark Brown
2025-09-02 21:02 ` Catalin Marinas
2025-09-03 10:01 ` Mark Brown
2025-09-03 15:34 ` Catalin Marinas
2025-09-05 15:21 ` Christian Brauner
2025-09-05 15:43 ` Mark Brown [this message]
2025-09-05 15:53 ` Edgecombe, Rick P
2025-09-05 16:00 ` Kees Cook
2025-09-05 16:02 ` Mark Brown
2025-09-15 14:29 ` Christian Brauner
2025-09-15 14:38 ` Mark Brown
2025-09-02 10:21 ` [PATCH v20 5/8] selftests/clone3: Remove redundant flushes of output streams Mark Brown
2025-09-02 10:21 ` [PATCH v20 6/8] selftests/clone3: Factor more of main loop into test_clone3() Mark Brown
2025-09-02 10:21 ` [PATCH v20 7/8] selftests/clone3: Allow tests to flag if -E2BIG is a valid error code Mark Brown
2025-09-02 10:21 ` [PATCH v20 8/8] selftests/clone3: Test shadow stack support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ff8b70e-283f-4d56-8bab-bcae11cd5bdb@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Szabolcs.Nagy@arm.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=debug@rivosinc.com \
--cc=dietmar.eggemann@arm.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wilco.dijkstra@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yury.khrustalev@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®