From: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
To: "broonie@kernel.org" <broonie@kernel.org>,
"brauner@kernel.org" <brauner@kernel.org>
Cc: "dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"Szabolcs.Nagy@arm.com" <Szabolcs.Nagy@arm.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"debug@rivosinc.com" <debug@rivosinc.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"fweimer@redhat.com" <fweimer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"vschneid@redhat.com" <vschneid@redhat.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"kees@kernel.org" <kees@kernel.org>,
"will@kernel.org" <will@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"jannh@google.com" <jannh@google.com>,
"yury.khrustalev@arm.com" <yury.khrustalev@arm.com>,
"bp@alien8.de" <bp@alien8.de>,
"wilco.dijkstra@arm.com" <wilco.dijkstra@arm.com>,
"bsegall@google.com" <bsegall@google.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>
Subject: Re: [PATCH v20 4/8] fork: Add shadow stack support to clone3()
Date: Fri, 5 Sep 2025 15:53:22 +0000 [thread overview]
Message-ID: <f374415d5738b8c69031cf57f27f4351045993d4.camel@intel.com> (raw)
In-Reply-To: <0ff8b70e-283f-4d56-8bab-bcae11cd5bdb@sirena.org.uk>
On Fri, 2025-09-05 at 16:43 +0100, Mark Brown wrote:
> On Fri, Sep 05, 2025 at 05:21:59PM +0200, Christian Brauner wrote:
> > On Tue, Sep 02, 2025 at 11:21:48AM +0100, Mark Brown wrote:
>
> > > + .shadow_stack_token = args.shadow_stack_token,
>
> > I'm not sure why this has to be named "shadow_stack_token" I think
> > that's just confusing and we should just call it "shadow_stack" and be
> > done with it. It's also a bit long of a field name imho.
>
> I'm not hugely attached to the name, if you want to rename that's
> perfectly fine by me. My thinking was that there's a potential
> confusion with it being a pointer to the base of the shadow stack by
> comparison with the existing "stack" but I do agree that the resulting
> name is quite long and if someone does actually get confused they should
> discover the problem fairly rapidly in testing. ss_token would shorter
> but the abbreviation is less clear, whatever name you prefer is fine by
> me.
Yea the token point here is kind of important. That said, we could probably make
up for it with documentation.
next prev parent reply other threads:[~2025-09-05 15:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 10:21 [PATCH v20 0/8] fork: Support shadow stacks in clone3() Mark Brown
2025-09-02 10:21 ` [PATCH v20 1/8] arm64/gcs: Return a success value from gcs_alloc_thread_stack() Mark Brown
2025-09-02 10:21 ` [PATCH v20 2/8] Documentation: userspace-api: Add shadow stack API documentation Mark Brown
2025-09-02 10:21 ` [PATCH v20 3/8] selftests: Provide helper header for shadow stack testing Mark Brown
2025-09-02 10:21 ` [PATCH v20 4/8] fork: Add shadow stack support to clone3() Mark Brown
2025-09-02 21:02 ` Catalin Marinas
2025-09-03 10:01 ` Mark Brown
2025-09-03 15:34 ` Catalin Marinas
2025-09-05 15:21 ` Christian Brauner
2025-09-05 15:43 ` Mark Brown
2025-09-05 15:53 ` Edgecombe, Rick P [this message]
2025-09-05 16:00 ` Kees Cook
2025-09-05 16:02 ` Mark Brown
2025-09-15 14:29 ` Christian Brauner
2025-09-15 14:38 ` Mark Brown
2025-09-02 10:21 ` [PATCH v20 5/8] selftests/clone3: Remove redundant flushes of output streams Mark Brown
2025-09-02 10:21 ` [PATCH v20 6/8] selftests/clone3: Factor more of main loop into test_clone3() Mark Brown
2025-09-02 10:21 ` [PATCH v20 7/8] selftests/clone3: Allow tests to flag if -E2BIG is a valid error code Mark Brown
2025-09-02 10:21 ` [PATCH v20 8/8] selftests/clone3: Test shadow stack support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f374415d5738b8c69031cf57f27f4351045993d4.camel@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=debug@rivosinc.com \
--cc=dietmar.eggemann@arm.com \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=juri.lelli@redhat.com \
--cc=kees@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wilco.dijkstra@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yury.khrustalev@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®