Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14 : NFO: trying to register non-static key. the code is fine but needs lockdep annotation.

[Sander Eikelenboom <linux@eikelenboom.it>]

Tuesday, February 11, 2014, 7:21:56 PM, you wrote:

> On 11/02/14 18:15, Roger Pau Monné wrote:
>> On 11/02/14 18:52, David Vrabel wrote:
>>> 
>> That would mean that unmap_purged_grants would no longer be static and 
>> I should also add a prototype for it in blkback/common.h, which is kind 
>> of ugly IMHO.

> But less ugly than initializing work with a NULL function, IMO.

>> commit 980e72e45454b64ccb7f23b6794a769384e51038
>> Author: Roger Pau Monne <roger.pau@citrix.com>
>> Date:   Tue Feb 11 19:04:06 2014 +0100
>> 
>>     xen-blkback: init persistent_purge_work work_struct
>>     
>>     Initialize persistent_purge_work work_struct on xen_blkif_alloc (and
>>     remove the previous initialization done in purge_persistent_gnt). This
>>     prevents flush_work from complaining even if purge_persistent_gnt has
>>     not been used.
>>     
>>     Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

> Reviewed-by: David Vrabel <david.vrabel@citrix.com>

And a Tested-by: Sander Eikelenboom <linux@eikelenboom.it>

Thanks !

> Thanks.

> David