From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Will Deacon <will@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Paul Burton <paul.burton@mips.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] sh: kgdb: Mark expected switch fall-throughs
Date: Tue, 10 Dec 2019 08:47:56 +0000 [thread overview]
Message-ID: <1009e85d-882a-d43b-8936-a0b4de596aa3@c-s.fr> (raw)
In-Reply-To: <87muc0y3q4.wl-kuninori.morimoto.gx@renesas.com>
On 12/10/2019 08:39 AM, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following error:
>
> LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
> LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
> if (kgdb_hex2long(&ptr, &addr))
> ^
> LINUX/arch/sh/kernel/kgdb.c:269:2: note: here
> case 'D':
> ^~~~
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
I guess you should also add:
Fixes: ab6e570ba33d ("sh: Generic kgdb stub support.")
Cc: stable@vger.kernel.org
Christophe
next prev parent reply other threads:[~2019-12-10 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 8:38 [PATCH][resend] " Kuninori Morimoto
2019-12-10 8:39 ` [PATCH] " Kuninori Morimoto
2019-12-10 8:47 ` Christophe Leroy [this message]
2019-12-11 15:18 ` Daniel Thompson
2019-12-10 20:12 ` [PATCH][resend] " Rob Landley
2019-12-10 20:20 ` Rob Landley
2019-12-10 22:28 ` Gustavo A. R. Silva
2019-12-11 9:17 ` Yoshinori Sato
-- strict thread matches above, loose matches on Subject: below --
2019-12-10 0:26 Kuninori Morimoto
2019-12-10 0:27 ` [PATCH] " Kuninori Morimoto
2019-10-30 7:17 Kuninori Morimoto
2019-10-30 8:44 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1009e85d-882a-d43b-8936-a0b4de596aa3@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®