From: Andrew Lunn <andrew@lunn.ch>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
Franz Schnyder <franz.schnyder@toradex.com>
Subject: Re: [PATCH v2 3/7] arm64: dts: freescale: Add Lino iMX93
Date: Tue, 15 Sep 2026 18:49:19 +0200 [thread overview]
Message-ID: <100eef7b-e1d6-411b-bac5-98790e8f9ea7@lunn.ch> (raw)
In-Reply-To: <20260915132806.GA226756@francesco-nb>
On Tue, Sep 15, 2026 at 03:28:06PM +0200, Francesco Dolcini wrote:
> Hello Andrew,
> thanks for the review.
>
> On Tue, Sep 15, 2026 at 03:19:45PM +0200, Andrew Lunn wrote:
> > > + ethphy1: ethernet-phy@1 {
> > > + reg = <1>;
> > > + interrupt-parent = <&adapter_gpio_expander>;
> > > + interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> >
> > Falling interrupts is probably wrong. They are normally level, active
> > low.
>
>
> It is wanted. The I2C ioexpander component used for the interrupt
> supports only edge interrupts. We tested it and it works fine like that.
It works, until it does not work, because you hit a race condition
with the hardware, two interrupts in quick succession. The second one
gets lost, and your link remains down forever.
> - when we tested it, the SW emulation was not really reliable, and we
> prefer to play on the safe side
If you want to be safe, delete the interrupt properties and let phylib
poll the PHY. That always works.
Andrew
next prev parent reply other threads:[~2026-09-15 16:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 9:19 [PATCH v2 0/7] arm64: dts: freescale: Add Toradex Lino and OSM iMX91/iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 1/7] dt-bindings: arm: fsl: Add Lino iMX91/iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 2/7] dt-bindings: arm: fsl: Add Toradex OSM iMX91/iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 3/7] arm64: dts: freescale: Add Lino iMX93 Francesco Dolcini
2026-09-11 14:30 ` Frank Li
2026-09-14 5:42 ` Francesco Dolcini
2026-09-14 14:28 ` Frank Li
2026-09-14 14:36 ` Francesco Dolcini
2026-09-15 13:19 ` Andrew Lunn
2026-09-15 13:28 ` Francesco Dolcini
2026-09-15 16:49 ` Andrew Lunn [this message]
2026-09-15 17:57 ` Francesco Dolcini
2026-09-15 19:57 ` Andrew Lunn
2026-09-16 5:57 ` Francesco Dolcini
2026-09-16 12:27 ` Andrew Lunn
2026-09-16 12:43 ` Francesco Dolcini
2026-09-16 13:03 ` Andrew Lunn
2026-09-11 9:19 ` [PATCH v2 4/7] arm64: dts: freescale: imx93-lino: Add dahlia Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 5/7] arm64: dts: freescale: Add Lino iMX91 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 6/7] arm64: dts: freescale: Add Toradex OSM iMX93 Francesco Dolcini
2026-09-11 9:19 ` [PATCH v2 7/7] arm64: dts: freescale: Add Toradex OSM iMX91 Francesco Dolcini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=100eef7b-e1d6-411b-bac5-98790e8f9ea7@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emanuele.ghidoli@toradex.com \
--cc=ernest.vanhoecke@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=franz.schnyder@toradex.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®