From: Jon Hunter <jonathanh@nvidia.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
"Alexandre Courbot" <gnurou@gmail.com>,
<linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] i2c: tegra: Remove non device-tree support
Date: Thu, 25 Aug 2016 21:49:37 +0100 [thread overview]
Message-ID: <1010511e-baa6-2792-90a4-30fc49628de8@nvidia.com> (raw)
In-Reply-To: <20160825193314.GB1614@katana>
On 25/08/16 20:33, Wolfram Sang wrote:
> * PGP Signed by an unknown key
>
> On Thu, Aug 11, 2016 at 11:16:56AM +0100, Jon Hunter wrote:
>> Tegra has only supported device-tree for platform/board configuration
>> for quite some time now and so simplify the Tegra I2C driver by dropping
>> code for non device-tree platforms/boards.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>
> cppcheck rightfully says:
>
> drivers/i2c/busses/i2c-tegra.c:854: style: Variable 'i2c_dev.hw' is reassigned a value before the old one has been used.
>
> Dropping the patches...
Yes good catch. I will fix that.
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-08-25 22:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 10:16 [PATCH 0/6] Some Tegra I2C Updates Jon Hunter
2016-08-11 10:16 ` [PATCH 1/6] i2c: tegra: Add missing new line characters Jon Hunter
2016-08-11 14:58 ` Laxman Dewangan
2016-08-11 10:16 ` [PATCH 2/6] i2c: tegra: Remove non device-tree support Jon Hunter
2016-08-11 14:59 ` Laxman Dewangan
2016-08-25 19:33 ` Wolfram Sang
2016-08-25 20:49 ` Jon Hunter [this message]
2016-08-11 10:16 ` [PATCH 3/6] i2c: tegra: Use device name for adapter name Jon Hunter
2016-08-11 14:59 ` Laxman Dewangan
2016-08-11 10:16 ` [PATCH 4/6] i2c: tegra: Simplify I2C resume Jon Hunter
2016-08-11 15:00 ` Laxman Dewangan
2016-08-11 10:16 ` [PATCH 5/6] i2c: tegra: Add runtime power-management support Jon Hunter
2016-08-11 15:01 ` Laxman Dewangan
2016-08-25 19:26 ` Wolfram Sang
2016-08-25 20:53 ` Jon Hunter
2016-08-25 22:31 ` Wolfram Sang
2016-08-11 10:17 ` [PATCH 6/6] i2c: tegra: Add pinctrl support Jon Hunter
2016-08-11 15:01 ` Laxman Dewangan
2016-08-24 11:10 ` [PATCH 0/6] Some Tegra I2C Updates Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010511e-baa6-2792-90a4-30fc49628de8@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®