From: Mark Brown <broonie@kernel.org>
To: Harendra Gautam <harendra.gautam@oss.qualcomm.com>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: qcom: lpass-cpu: Use asoc_qcom_of_xlate_dai_name helper
Date: Fri, 5 Jun 2026 13:21:31 +0100 [thread overview]
Message-ID: <1011c7bf-14f7-444f-af7d-3973a2e6bfb5@sirena.org.uk> (raw)
In-Reply-To: <20260605092812.3495852-3-harendra.gautam@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Fri, Jun 05, 2026 at 02:58:12PM +0530, Harendra Gautam wrote:
> Replace the private static asoc_qcom_of_xlate_dai_name() implementation
> in lpass-cpu.c with a thin wrapper that calls the new shared helper
> from common.c. This removes the duplicate implementation.
>
> Signed-off-by: Harendra Gautam <harendra.gautam@oss.qualcomm.com>
> ---
> sound/soc/qcom/lpass-cpu.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c
> index 242bc16da36d..35c2c8030024 100644
> --- a/sound/soc/qcom/lpass-cpu.c
> +++ b/sound/soc/qcom/lpass-cpu.c
> @@ -18,6 +18,7 @@
> #include <sound/soc-dai.h>
> #include "lpass-lpaif-reg.h"
> #include "lpass.h"
> +#include "common.h"
Did you double check that all users of LPASS select SND_SOC_QCOM_COMMON?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-06-05 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 9:28 [PATCH 0/2] ASoC: qcom: Refactor of_xlate_dai_name into common helper Harendra Gautam
2026-06-05 9:28 ` [PATCH 1/2] ASoC: qcom: Add generic of_xlate_dai_name helper to common Harendra Gautam
2026-06-05 9:28 ` [PATCH 2/2] ASoC: qcom: lpass-cpu: Use asoc_qcom_of_xlate_dai_name helper Harendra Gautam
2026-06-05 12:21 ` Mark Brown [this message]
2026-06-05 9:41 ` [PATCH 0/2] ASoC: qcom: Refactor of_xlate_dai_name into common helper Srinivas Kandagatla
2026-06-05 12:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1011c7bf-14f7-444f-af7d-3973a2e6bfb5@sirena.org.uk \
--to=broonie@kernel.org \
--cc=harendra.gautam@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®