mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srini@kernel.org>
To: Harendra Gautam <harendra.gautam@oss.qualcomm.com>,
	Srinivas Kandagatla <srini@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] ASoC: qcom: Refactor of_xlate_dai_name into common helper
Date: Fri, 5 Jun 2026 10:41:33 +0100	[thread overview]
Message-ID: <e256edef-fc24-4ccc-b031-4387a127fc83@kernel.org> (raw)
In-Reply-To: <20260605092812.3495852-1-harendra.gautam@oss.qualcomm.com>



On 6/5/26 10:28 AM, Harendra Gautam wrote:
> Multiple Qualcomm ASoC CPU DAI drivers implement the same logic to
> resolve a sound-dai phandle argument to a DAI name: iterate the
> component's DAI driver array and match by ID. This is currently
> duplicated between lpass-cpu.c and qaif-cpu.c.
> 
> This series extracts the common logic into a shared helper
> asoc_qcom_of_xlate_dai_name() in common.c and refactors lpass-cpu.c
> to use it. The QAIF driver (in a separate series) will also use this
> helper instead of its own private implementation.
> 
> Patch 1: Add asoc_qcom_of_xlate_dai_name() to common.c/h
> Patch 2: Refactor lpass-cpu.c to use the new helper

series itself does not make sense, as you only have one user for this at
the moment.

Please consider making it part of the series that actually has more than
one user for this.


--srini
> 
> Harendra Gautam (2):
>   ASoC: qcom: Add generic of_xlate_dai_name helper to common
>   ASoC: qcom: lpass-cpu: Use asoc_qcom_of_xlate_dai_name helper
> 
>  sound/soc/qcom/common.c    | 34 ++++++++++++++++++++++++++++++++++
>  sound/soc/qcom/common.h    |  5 +++++
>  sound/soc/qcom/lpass-cpu.c | 19 +++++--------------
>  3 files changed, 44 insertions(+), 14 deletions(-)
> 


  parent reply	other threads:[~2026-06-05  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-05  9:28 Harendra Gautam
2026-06-05  9:28 ` [PATCH 1/2] ASoC: qcom: Add generic of_xlate_dai_name helper to common Harendra Gautam
2026-06-05  9:28 ` [PATCH 2/2] ASoC: qcom: lpass-cpu: Use asoc_qcom_of_xlate_dai_name helper Harendra Gautam
2026-06-05 12:21   ` Mark Brown
2026-06-05  9:41 ` Srinivas Kandagatla [this message]
2026-06-05 12:23   ` [PATCH 0/2] ASoC: qcom: Refactor of_xlate_dai_name into common helper Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e256edef-fc24-4ccc-b031-4387a127fc83@kernel.org \
    --to=srini@kernel.org \
    --cc=broonie@kernel.org \
    --cc=harendra.gautam@oss.qualcomm.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®