From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com, arvind.chauhan@arm.com
Subject: Re: [PATCH 0/3] CPUFreq Fixes for 3.10-rc2
Date: Fri, 17 May 2013 14:16:23 +0200 [thread overview]
Message-ID: <10164364.7LZaY8si4T@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpomOzeHsv=ZDBJGQKAiFWHDczweWF1wZuQDMRZE-0U3=2A@mail.gmail.com>
On Friday, May 17, 2013 10:13:37 AM Viresh Kumar wrote:
> On 17 May 2013 02:21, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > While I kind of understand why you want [3/3] to go into 3.10, I'm wondering
> > about the other two patches. Why exactly are they needed now?
>
> First one:
>
> cpufreq: Add EXPORT_SYMBOL_GPL for have_governor_per_policy
>
> is required so that governors can be compiled as module. Otherwise they
> may break.. I haven't tried that but I believe that is the case.
Did you try to build them as modules?
> For second one:
>
> cpufreq: governors: Move get_governor_parent_kobj() to cpufreq.c
>
> I was actually working on Android's Interactive governor (Where I enabled
> same per-policy-instance of governor support), And i required this patch
> for its working. Then I thought other platform specific governors present
> in mainline might also use this routine and so must be pushed to cpufreq.c.
>
> Now, because this patch is around due to something which got
> added in 3.10-rc1, its better to fix it in rcs only rather than fixing
> it in 3.11.
OK, thanks for the explanation.
> I will trust your judgement here, push it for 3.10-rc if it looks okay to you.
>
> > And speaking of patch [3/3], if you paste kernel logs into changelogs, please
> > remove the time stamps (unless they are relevant to the problem being fixed).
>
> Okay.. Will keep that in mind.
Thanks!
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-05-17 12:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 5:09 Viresh Kumar
2013-05-16 5:09 ` [PATCH 1/3] cpufreq: Add EXPORT_SYMBOL_GPL for have_governor_per_policy Viresh Kumar
2013-05-16 5:09 ` [PATCH 2/3] cpufreq: governors: Move get_governor_parent_kobj() to cpufreq.c Viresh Kumar
2013-05-16 5:09 ` [PATCH 3/3] cpufreq: Drop rwsem lock around CPUFREQ_GOV_POLICY_EXIT Viresh Kumar
2013-05-16 8:46 ` [PATCH 0/3] CPUFreq Fixes for 3.10-rc2 Rafael J. Wysocki
2013-05-16 8:39 ` Viresh Kumar
2013-05-16 20:51 ` Rafael J. Wysocki
2013-05-17 4:43 ` Viresh Kumar
2013-05-17 12:16 ` Rafael J. Wysocki [this message]
2013-05-17 13:52 ` Viresh Kumar
2013-05-17 23:40 ` Rafael J. Wysocki
2013-05-18 2:15 ` Viresh Kumar
2013-05-18 9:16 ` Rafael J. Wysocki
2013-05-18 11:30 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10164364.7LZaY8si4T@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=robin.randhawa@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®