SMBfs / Unicode problem perhaps?

SMBfs / Unicode problem perhaps?

[Peter J. Milanese]

Greetings-

 I don't know if this is just for my compile, or if this has been seen as a
problem yet. I recently set up 2.5.13, however the same issue persisted with
2.5.7 as well. I can successfully mount smbfs, however, it seems that the
directory contents are not translated correctly.

bash-2.04$ ls -la
ls: b: No such file or directory
ls: d: No such file or directory
ls: m: No such file or directory
ls: M: No such file or directory
ls: r: No such file or directory
ls: R: No such file or directory
ls: r: No such file or directory
ls: R: No such file or directory
ls: s: No such file or directory
ls: w: No such file or directory

Every 1st letter of the directory contents.

I could not find anything about this in the archive, and was curious as to
anyone else having this problem, and any input I could get-

Thanks

P

Re: SMBfs / Unicode problem perhaps?

[Urban Widmark]

On Sat, 4 May 2002, Peter J. Milanese wrote:

> Every 1st letter of the directory contents.
> 
> I could not find anything about this in the archive, and was curious as to
> anyone else having this problem, and any input I could get-

Look for some messages from 3 days ago. You need to upgrade your samba to
2.2.3a.

/Urban

Re: SMBfs / Unicode problem perhaps?

[Peter J. Milanese]

Greeting Urban-

Quoting Urban Widmark <urban@teststation.com>:

> On Sat, 4 May 2002, Peter J. Milanese wrote:
> 
> > Every 1st letter of the directory contents.
> > 
> > I could not find anything about this in the archive, and was curious as
> to
> > anyone else having this problem, and any input I could get-
> 
> Look for some messages from 3 days ago. You need to upgrade your samba to
> 2.2.3a.

:\ - I am running 2.2.3a... I'll look at those messages and see if there is a
corelation. Thanks for the tip-

P

> 
> /Urban
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: SMBfs / Unicode problem perhaps?

[Urban Widmark]

On Sun, 5 May 2002, Peter J. Milanese wrote:

> :\ - I am running 2.2.3a... I'll look at those messages and see if there is a
> corelation. Thanks for the tip-

Are you sure your smbmount is 2.2.3a and that you don't have a mix of an
old 2.2.1a install? smbmount from 2.2.3a should not negotiate unicode
unless you told it to ...

You could also try the untested patch below that only enables it if you
also specify "codepage=unicode" as a mount option.

/Urban


diff -urN -X exclude linux-2.5.13-kbuild-orig/fs/smbfs/proc.c linux-2.5.13-kbuild-smbfs/fs/smbfs/proc.c
--- linux-2.5.13-kbuild-orig/fs/smbfs/proc.c	Fri May  3 02:22:42 2002
+++ linux-2.5.13-kbuild-smbfs/fs/smbfs/proc.c	Sun May  5 14:53:08 2002
@@ -979,7 +979,9 @@
 		SB_of(server)->s_maxbytes = ~0ULL >> 1;
 		VERBOSE("LFS enabled\n");
 	}
-	if (server->opt.capabilities & SMB_CAP_UNICODE) {
+	if (server->opt.capabilities & SMB_CAP_UNICODE &&
+	    server->remote_nls == &unicode_table) {
+		/* Only enable unicode if the remote nls is also unicode */
 		server->mnt->flags |= SMB_MOUNT_UNICODE;
 		VERBOSE("Unicode enabled\n");
 	} else {

Re: SMBfs / Unicode problem perhaps?

[Peter J. Milanese]

Bah...

I did find some old libs on the box...

I've cleaned that all up, and I'm currently compiling 2.2.4 to see how it goes.
I will back it to 2.2.3a again (clean) if there's a problem with that, but the 
notes don't say anything negative. I will go with the patch below IF it comes 
to that, but I'd imagine the old libs were suspect.

Thanks for openning my mind.... :)

P


Quoting Urban Widmark <urban@teststation.com>:

> On Sun, 5 May 2002, Peter J. Milanese wrote:
> 
> > :\ - I am running 2.2.3a... I'll look at those messages and see if there is
> a
> > corelation. Thanks for the tip-
> 
> Are you sure your smbmount is 2.2.3a and that you don't have a mix of an
> old 2.2.1a install? smbmount from 2.2.3a should not negotiate unicode
> unless you told it to ...
> 
> You could also try the untested patch below that only enables it if you
> also specify "codepage=unicode" as a mount option.
> 
> /Urban
> 
> 
> diff -urN -X exclude linux-2.5.13-kbuild-orig/fs/smbfs/proc.c
> linux-2.5.13-kbuild-smbfs/fs/smbfs/proc.c
> --- linux-2.5.13-kbuild-orig/fs/smbfs/proc.c	Fri May  3 02:22:42 2002
> +++ linux-2.5.13-kbuild-smbfs/fs/smbfs/proc.c	Sun May  5 14:53:08 2002
> @@ -979,7 +979,9 @@
>  		SB_of(server)->s_maxbytes = ~0ULL >> 1;
>  		VERBOSE("LFS enabled\n");
>  	}
> -	if (server->opt.capabilities & SMB_CAP_UNICODE) {
> +	if (server->opt.capabilities & SMB_CAP_UNICODE &&
> +	    server->remote_nls == &unicode_table) {
> +		/* Only enable unicode if the remote nls is also unicode */
>  		server->mnt->flags |= SMB_MOUNT_UNICODE;
>  		VERBOSE("Unicode enabled\n");
>  	} else {
> 
>