mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Fix compilation warning in do_mounts.c
@ 2002-05-24  5:46 Peter Chubb
  2002-05-24 15:22 ` Robert Love
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Chubb @ 2002-05-24  5:46 UTC (permalink / raw)
  To: linux-kernel, trivial


Hi,
	change_floppy() is unused if you don't have the floppy device
compiled into the kernel --- so why not #ifdef it out?

===== init/do_mounts.c 1.14 vs edited =====
--- 1.14/init/do_mounts.c	Mon May  6 02:35:44 2002
+++ edited/init/do_mounts.c	Fri May 24 15:46:28 2002
@@ -364,6 +364,7 @@
 	return sys_symlink(path + n + 5, name);
 }
 
+#if defined(BLOCK_DEV_RAM) || defined(CONFIG_BLK_DEV_FD)
 static void __init change_floppy(char *fmt, ...)
 {
 	struct termios termios;
@@ -391,6 +392,7 @@
 		close(fd);
 	}
 }
+#endif
 
 #ifdef CONFIG_BLK_DEV_RAM
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix compilation warning in do_mounts.c
  2002-05-24  5:46 Fix compilation warning in do_mounts.c Peter Chubb
@ 2002-05-24 15:22 ` Robert Love
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2002-05-24 15:22 UTC (permalink / raw)
  To: Peter Chubb; +Cc: linux-kernel, trivial

On Thu, 2002-05-23 at 22:46, Peter Chubb wrote:

> 	change_floppy() is unused if you don't have the floppy device
> compiled into the kernel --- so why not #ifdef it out?

Heh I was getting to the point of annoyance where I was about to do this
same thing.  Good.

There are a few other similar warnings with other functions, too ... :)

	Robert Love


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-05-24 15:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-24  5:46 Fix compilation warning in do_mounts.c Peter Chubb
2002-05-24 15:22 ` Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®