mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Replacing strtok with strsep
@ 2002-07-03  4:39 Bongani
  0 siblings, 0 replies; only message in thread
From: Bongani @ 2002-07-03  4:39 UTC (permalink / raw)
  To: langa2; +Cc: Linux Kernel

Hi

You are listed as the maintainer of this driver so I'm sending this to
you. This patch is against 2.5.24, it replaces strtok with a thread safe
strsep as listed on the Kernel-Janitor's TODO file. Could you please
verify that it is OK.

Thanx


--- linux-2.5/drivers/scsi/ibmmca.c_orig	Wed Jun 26 23:50:11 2002
+++ linux-2.5/drivers/scsi/ibmmca.c	Wed Jun 26 23:50:40 2002
@@ -1406,9 +1406,8 @@
    io_base = 0;
    id_base = 0;
    if (str) {
-      token = strtok(str,",");
       j = 0;
-      while (token) {
+      while (token = strsep(&str,",")) {
 	 if (!strcmp(token,"activity")) display_mode |= LED_ACTIVITY;
 	 if (!strcmp(token,"display")) display_mode |= LED_DISP;
 	 if (!strcmp(token,"adisplay")) display_mode |= LED_ADISP;
@@ -1424,7 +1423,6 @@
 	      scsi_id[id_base++] = simple_strtoul(token,NULL,0);
 	    j++;
 	 }
-	 token = strtok(NULL,",");
       }
    } else if (ints) {
       for (i = 0; i < IM_MAX_HOSTS && 2*i+2 < ints[0]; i++) {




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-07-03  4:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-03  4:39 [PATCH] Replacing strtok with strsep Bongani

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®