From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: colpatch@us.ibm.com
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, Martin Bligh <mjbligh@us.ibm.com>,
Michael Hohnbaum <hohnbaum@us.ibm.com>,
Greg KH <gregkh@us.ibm.com>
Subject: Re: [patch] PCI Cleanup
Date: 13 Aug 2002 12:45:33 +0100 [thread overview]
Message-ID: <1029239133.20980.10.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <3D584DF8.9020206@us.ibm.com>
On Tue, 2002-08-13 at 01:08, Matthew Dobson wrote:
> - if (!value)
> - return -EINVAL;
> -
> - result = pci_conf1_read(0, dev->bus->number, PCI_SLOT(dev->devfn),
> - PCI_FUNC(dev->devfn), where, 2, &data);
> -
This stil has the same problems as it did last time you posted it. The
pointless NULL check and the increased complexity over duplicating about
60 lines of code and having pci_conf1 ops cleanly as we do in 2.4.
The !value check is extremely bad because it turns a critical debuggable
software error into a silent unnoticed mistake.
Fixing the code instead of just resending it might improve the changes
of it being merged no end.
Alan
next prev parent reply other threads:[~2002-08-13 11:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-13 0:08 Matthew Dobson
2002-08-13 11:45 ` Alan Cox [this message]
2002-08-13 14:17 ` Martin J. Bligh
2002-08-13 14:57 ` Alan Cox
2002-08-13 15:15 ` Martin J. Bligh
2002-08-13 17:00 ` Matthew Dobson
2002-08-13 17:23 ` Linus Torvalds
2002-08-13 19:57 ` Martin J. Bligh
2002-08-13 20:13 ` Alan Cox
2002-08-13 20:26 ` Linus Torvalds
2002-08-13 22:29 ` Matthew Dobson
2002-08-13 22:46 ` Linus Torvalds
2002-08-14 0:57 ` Matthew Dobson
2002-08-15 0:23 ` Matthew Dobson
2002-08-14 7:08 ` Martin Mares
2002-08-13 14:55 ` Martin J. Bligh
2002-08-13 15:07 ` Alan Cox
2002-08-15 2:24 Grover, Andrew
2002-08-15 7:49 ` Martin Mares
2002-08-15 15:58 ` Kai Germaschewski
2002-08-15 16:36 ` Greg KH
2002-08-16 22:34 ` Greg KH
2002-08-19 23:41 ` Matthew Dobson
2002-08-15 18:28 ` Patrick Mochel
2002-08-15 20:23 Grover, Andrew
2002-08-15 20:54 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1029239133.20980.10.camel@irongate.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=colpatch@us.ibm.com \
--cc=gregkh@us.ibm.com \
--cc=hohnbaum@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjbligh@us.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®