From: "Grover, Andrew" <andrew.grover@intel.com>
To: "'colpatch@us.ibm.com'" <colpatch@us.ibm.com>,
Linus Torvalds <torvalds@transmeta.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Martin J. Bligh" <Martin.Bligh@us.ibm.com>,
linux-kernel@vger.kernel.org,
Michael Hohnbaum <hohnbaum@us.ibm.com>,
Greg KH <gregkh@us.ibm.com>,
jgarzik@mandrakesoft.com, "Grover,
Andrew" <andrew.grover@intel.com>,
"Diefenbaugh, Paul S" <paul.s.diefenbaugh@intel.com>
Subject: RE: [patch] PCI Cleanup
Date: Wed, 14 Aug 2002 19:24:49 -0700 [thread overview]
Message-ID: <EDC461A30AC4D511ADE10002A5072CAD0236DD92@orsmsx119.jf.intel.com> (raw)
> From: Matthew Dobson [mailto:colpatch@us.ibm.com]
> OK... Here's the latest version. Sorry about that last
> posting... Stupid line
> wrapping broke the patch! :( This patch also removes the
> pci_config_(read|write) function pointers. People shouldn't
> be using these (I
> don't think) and should be using the pci_ops structure linked
> through the
> pci_dev structure. These end up calling the same functions that the
> pci_config_(read|write) pointers refer to anyway. The only
> places I can see
> that these are being used in the kernel are in
> drivers/acpi/osl.c... Anyone
> care to comment on the use there or if it can be changed?
> I've cc'd the
> authors of the file...
Hi Matthew,
ACPI needs access to PCI config space, and it doesn't have a struct pci_dev
to pass to access functions. It doesn't look like your patch exposes an
interface that 1) doesn't require a pci_dev and 2) abstracts the PCI config
access method, does it?
Regards -- Andy
next reply other threads:[~2002-08-15 2:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-15 2:24 Grover, Andrew [this message]
2002-08-15 7:38 ` [PATCH] Fixup pci_alloc_consistent with 64bit DMA masks on i386 Steffen Persvold
2002-08-15 7:49 ` [patch] PCI Cleanup Martin Mares
2002-08-15 15:58 ` Kai Germaschewski
2002-08-15 16:36 ` Greg KH
2002-08-16 22:34 ` Greg KH
2002-08-19 23:41 ` Matthew Dobson
2002-08-15 18:28 ` Patrick Mochel
-- strict thread matches above, loose matches on Subject: below --
2002-08-15 20:23 Grover, Andrew
2002-08-15 20:54 ` Patrick Mochel
2002-08-13 0:08 Matthew Dobson
2002-08-13 11:45 ` Alan Cox
2002-08-13 14:17 ` Martin J. Bligh
2002-08-13 14:57 ` Alan Cox
2002-08-13 15:15 ` Martin J. Bligh
2002-08-13 17:00 ` Matthew Dobson
2002-08-13 17:23 ` Linus Torvalds
2002-08-13 19:57 ` Martin J. Bligh
2002-08-13 20:13 ` Alan Cox
2002-08-13 20:26 ` Linus Torvalds
2002-08-13 22:29 ` Matthew Dobson
2002-08-13 22:46 ` Linus Torvalds
2002-08-14 0:57 ` Matthew Dobson
2002-08-15 0:23 ` Matthew Dobson
2002-08-14 7:08 ` Martin Mares
2002-08-13 14:55 ` Martin J. Bligh
2002-08-13 15:07 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EDC461A30AC4D511ADE10002A5072CAD0236DD92@orsmsx119.jf.intel.com \
--to=andrew.grover@intel.com \
--cc=Martin.Bligh@us.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=colpatch@us.ibm.com \
--cc=gregkh@us.ibm.com \
--cc=hohnbaum@us.ibm.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.s.diefenbaugh@intel.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®