mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yanhong Wang <yanhong.wang@starfivetech.com>,
	linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Emil Renner Berthing <kernel@esmil.dk>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v4 4/7] dt-bindings: net: Add support StarFive dwmac
Date: Wed, 18 Jan 2023 16:49:33 +0100	[thread overview]
Message-ID: <102db6ae-742b-ea20-076e-386a0284a185@linaro.org> (raw)
In-Reply-To: <20230118061701.30047-5-yanhong.wang@starfivetech.com>

On 18/01/2023 07:16, Yanhong Wang wrote:
> Add documentation to describe StarFive dwmac driver(GMAC).
> 
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>


Subject is poor. You miss device prefix and it's not correct sentence.

"Add support for XYZ"
or better:
"Add XYZ"


> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml   |   1 +
>  .../bindings/net/starfive,jh7110-dwmac.yaml   | 113 ++++++++++++++++++
>  MAINTAINERS                                   |   5 +
>  3 files changed, 119 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index baf2c5b9e92d..8b07bc9c8b00 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -91,6 +91,7 @@ properties:
>          - snps,dwmac-5.20
>          - snps,dwxgmac
>          - snps,dwxgmac-2.10
> +        - starfive,jh7110-dwmac
>  
>    reg:
>      minItems: 1
> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> new file mode 100644
> index 000000000000..eb0767da834a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2022 StarFive Technology Co., Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive JH7110 DWMAC glue layer
> +
> +maintainers:
> +  - Yanhong Wang <yanhong.wang@starfivetech.com>
> +
> +select:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - starfive,jh7110-dwmac
> +  required:
> +    - compatible
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - starfive,jh7110-dwmac
> +      - const: snps,dwmac-5.20
> +
> +  clocks:
> +    items:
> +      - description: GMAC main clock
> +      - description: GMAC AHB clock
> +      - description: PTP clock
> +      - description: TX clock
> +      - description: GTXC clock
> +      - description: GTX clock
> +
> +  clock-names:
> +    items:
> +      - const: stmmaceth
> +      - const: pclk
> +      - const: ptp_ref
> +      - const: tx
> +      - const: gtxc
> +      - const: gtx
> +
> +  resets:
> +    items:
> +      - description: MAC Reset signal.

Drop trailing dot

> +      - description: AHB Reset signal.

Ditto

> +
> +  reset-names:
> +    items:
> +      - const: stmmaceth
> +      - const: ahb

You have two resets. Why do you change them to three for all variants?
It's not explained in commit 2/7, so this is confusing.

> +
> +allOf:
> +  - $ref: snps,dwmac.yaml#
> +
> +unevaluatedProperties: true
> +
> +required:
> +  - compatible
> +  - clocks
> +  - clock-names
> +  - resets
> +  - reset-names
> +


Best regards,
Krzysztof


  reply	other threads:[~2023-01-18 15:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  6:16 [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 1/7] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2023-01-18 13:10   ` Rob Herring
2023-01-18 15:46   ` Krzysztof Kozlowski
2023-01-18 15:47   ` Krzysztof Kozlowski
2023-02-07  2:43     ` yanhong wang
2023-02-07  7:59       ` Krzysztof Kozlowski
2023-02-15  7:46         ` yanhong wang
2023-02-16  8:13           ` Krzysztof Kozlowski
2023-01-18  6:16 ` [PATCH v4 3/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2023-01-18  6:16 ` [PATCH v4 4/7] dt-bindings: net: Add support StarFive dwmac Yanhong Wang
2023-01-18 15:49   ` Krzysztof Kozlowski [this message]
2023-02-03  5:58     ` yanhong wang
2023-01-18  6:16 ` [PATCH v4 5/7] net: stmmac: Add glue layer for StarFive JH7110 SoCs Yanhong Wang
2023-02-16 10:53   ` Emil Renner Berthing
2023-02-21  2:27     ` yanhong wang
2023-02-26 15:15       ` Emil Renner Berthing
2023-01-18  6:17 ` [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2023-01-18 15:51   ` Krzysztof Kozlowski
2023-02-03  3:14     ` yanhong wang
2023-02-03  7:09       ` Krzysztof Kozlowski
2023-02-03  7:40         ` yanhong wang
2023-02-03  7:56           ` Krzysztof Kozlowski
2023-02-03  9:01             ` yanhong wang
2023-02-20 14:22   ` Emil Renner Berthing
2023-02-20 15:00     ` Emil Renner Berthing
2023-01-18  6:17 ` [PATCH v4 7/7] riscv: dts: starfive: visionfive-v2: Enable gmac device tree node Yanhong Wang
2023-02-20 14:05   ` Emil Renner Berthing
2023-01-18 23:21 ` [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Conor Dooley
2023-02-03  3:02   ` yanhong wang
2023-02-04 14:22     ` Conor Dooley
2023-02-04 17:16       ` Andrew Lunn
2023-02-05 10:11         ` Conor Dooley
2023-02-06  1:15         ` yanhong wang
2023-02-06  1:05       ` yanhong wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=102db6ae-742b-ea20-076e-386a0284a185@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@esmil.dk \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pgwipeout@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yanhong.wang@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®