From: Rob Herring <robh@kernel.org>
To: Yanhong Wang <yanhong.wang@starfivetech.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
Peter Geis <pgwipeout@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
devicetree@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names
Date: Wed, 18 Jan 2023 07:10:47 -0600 [thread overview]
Message-ID: <167404705359.1390391.205840489556921087.robh@kernel.org> (raw)
In-Reply-To: <20230118061701.30047-3-yanhong.wang@starfivetech.com>
On Wed, 18 Jan 2023 14:16:56 +0800, Yanhong Wang wrote:
> Some boards(such as StarFive VisionFive v2) require more than one value
> which defined by resets property, so the original definition can not
> meet the requirements. In order to adapt to different requirements,
> adjust the maxitems number definition.
>
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.example.dtb: ethernet@1c0b000: Unevaluated properties are not allowed ('reset-names' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.example.dtb: ethernet@1c0b000: Unevaluated properties are not allowed ('reset-names' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.example.dtb: ethernet@1c0b000: Unevaluated properties are not allowed ('reset-names' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230118061701.30047-3-yanhong.wang@starfivetech.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-01-18 13:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 6:16 [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-01-18 6:16 ` [PATCH v4 1/7] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2023-01-18 6:16 ` [PATCH v4 2/7] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2023-01-18 13:10 ` Rob Herring [this message]
2023-01-18 15:46 ` Krzysztof Kozlowski
2023-01-18 15:47 ` Krzysztof Kozlowski
2023-02-07 2:43 ` yanhong wang
2023-02-07 7:59 ` Krzysztof Kozlowski
2023-02-15 7:46 ` yanhong wang
2023-02-16 8:13 ` Krzysztof Kozlowski
2023-01-18 6:16 ` [PATCH v4 3/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2023-01-18 6:16 ` [PATCH v4 4/7] dt-bindings: net: Add support StarFive dwmac Yanhong Wang
2023-01-18 15:49 ` Krzysztof Kozlowski
2023-02-03 5:58 ` yanhong wang
2023-01-18 6:16 ` [PATCH v4 5/7] net: stmmac: Add glue layer for StarFive JH7110 SoCs Yanhong Wang
2023-02-16 10:53 ` Emil Renner Berthing
2023-02-21 2:27 ` yanhong wang
2023-02-26 15:15 ` Emil Renner Berthing
2023-01-18 6:17 ` [PATCH v4 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2023-01-18 15:51 ` Krzysztof Kozlowski
2023-02-03 3:14 ` yanhong wang
2023-02-03 7:09 ` Krzysztof Kozlowski
2023-02-03 7:40 ` yanhong wang
2023-02-03 7:56 ` Krzysztof Kozlowski
2023-02-03 9:01 ` yanhong wang
2023-02-20 14:22 ` Emil Renner Berthing
2023-02-20 15:00 ` Emil Renner Berthing
2023-01-18 6:17 ` [PATCH v4 7/7] riscv: dts: starfive: visionfive-v2: Enable gmac device tree node Yanhong Wang
2023-02-20 14:05 ` Emil Renner Berthing
2023-01-18 23:21 ` [PATCH v4 0/7] Add Ethernet driver for StarFive JH7110 SoC Conor Dooley
2023-02-03 3:02 ` yanhong wang
2023-02-04 14:22 ` Conor Dooley
2023-02-04 17:16 ` Andrew Lunn
2023-02-05 10:11 ` Conor Dooley
2023-02-06 1:15 ` yanhong wang
2023-02-06 1:05 ` yanhong wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167404705359.1390391.205840489556921087.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®