* mediatek: media: Missing alloc null test
@ 2024-02-17 19:44 Joe Perches
0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2024-02-17 19:44 UTC (permalink / raw)
To: Tiffany Lin, Andrew-CT Chen, Yunfei Dong
Cc: Mauro Carvalho Chehab, Matthias Brugger,
AngeloGioacchino Del Regno, linux-media, linux-kernel,
linux-arm-kernel, linux-mediatek
There's a missing NULL alloc test here:
It doesn't appear obvious what a proper fix is.
diff -u -p ./drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_scp.c /tmp/nothing/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_scp.c
--- ./drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_scp.c
+++ /tmp/nothing/drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_scp.c
@@ -79,7 +79,6 @@ struct mtk_vcodec_fw *mtk_vcodec_fw_scp_
}
fw = devm_kzalloc(&plat_dev->dev, sizeof(*fw), GFP_KERNEL);
- fw->type = SCP;
fw->ops = &mtk_vcodec_rproc_msg;
fw->scp = scp;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-17 19:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-17 19:44 mediatek: media: Missing alloc null test Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®