mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] have lockd and rpciod drop locks on exit
@ 2002-08-29 15:31 Robert Love
  0 siblings, 0 replies; only message in thread
From: Robert Love @ 2002-08-29 15:31 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel

Linus,

Neither lockd nor rpciod properly drop the BKL on exit.

Yes, the BKL is automatically relinquished on schedule but the failure
to drop the lock throws off the atomic accounting and results in a
preempt_count warning on exit.

This makes them play fair - it does not hurt.

Patch is against 2.5.32-bk.  Please, apply.

        Robert Love

diff -urN linux-2.5.32/fs/lockd/svc.c linux/fs/lockd/svc.c
--- linux-2.5.32/fs/lockd/svc.c	Tue Aug 27 15:26:51 2002
+++ linux/fs/lockd/svc.c	Wed Aug 28 17:42:50 2002
@@ -203,6 +203,7 @@
 	rpciod_down();
 
 	/* Release module */
+	unlock_kernel();
 	MOD_DEC_USE_COUNT;
 }
 
diff -urN linux-2.5.32/net/sunrpc/sched.c linux/net/sunrpc/sched.c
--- linux-2.5.32/net/sunrpc/sched.c	Tue Aug 27 15:26:43 2002
+++ linux/net/sunrpc/sched.c	Wed Aug 28 17:42:50 2002
@@ -1030,6 +1030,7 @@
 	wake_up(assassin);
 
 	dprintk("RPC: rpciod exiting\n");
+	unlock_kernel();
 	MOD_DEC_USE_COUNT;
 	return 0;
 }



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-08-29 15:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-29 15:31 [PATCH] have lockd and rpciod drop locks on exit Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®