* [PATCH] 2.5.45 : net/ipv4/ipconfig.c
@ 2002-11-02 7:43 Frank Davis
2002-11-02 10:14 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Frank Davis @ 2002-11-02 7:43 UTC (permalink / raw)
To: linux-kernel; +Cc: fdavis
Hello all,
The following patch moves a variable to a place prior to a label (no
reinitialization). Please review.
Regards,
Frank
--- linux/net/ipv4/ipconfig.c.old Sat Oct 19 12:08:27 2002
+++ linux/net/ipv4/ipconfig.c Fri Nov 1 22:02:27 2002
@@ -1144,6 +1144,7 @@
DBG(("IP-Config: Entered.\n"));
#ifdef IPCONFIG_DYNAMIC
+ int retries = CONF_OPEN_RETRIES;
try_try_again:
#endif
/* Give hardware a chance to settle */
@@ -1175,8 +1176,6 @@
ic_first_dev->next) {
#ifdef IPCONFIG_DYNAMIC
- int retries = CONF_OPEN_RETRIES;
-
if (ic_dynamic() < 0) {
ic_close_devs();
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.5.45 : net/ipv4/ipconfig.c
2002-11-02 7:43 [PATCH] 2.5.45 : net/ipv4/ipconfig.c Frank Davis
@ 2002-11-02 10:14 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2002-11-02 10:14 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel
On Fri, 2002-11-01 at 23:43, Frank Davis wrote:
> Hello all,
> The following patch moves a variable to a place prior to a label (no
> reinitialization). Please review.
I definitely consider the existing code much cleaner, and GCC
allocated registers much more effectively when you place variables
only in the inner most scope in which they are used.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-11-02 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-02 7:43 [PATCH] 2.5.45 : net/ipv4/ipconfig.c Frank Davis
2002-11-02 10:14 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®