[PATCH] Fixup pci_alloc_consistent with 64bit DMA masks on i386

[PATCH] Fixup pci_alloc_consistent with 64bit DMA masks on i386

[Steffen Persvold]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 595 bytes --]

Hi Marcello,

I posted this small one-liner to Alan Cox (and to the lkml) in August but 
it doesn't seem to have gotten into the mainline yet (I think it is in -ac).

The issue is that PCI drivers which uses 64bit DMA masks (in order to do 
DAC) is making unnecessary use of the DMA zone memory (the <16Meg region 
on i386) when doing pci_alloc_consitent().

Hope this gets into the next -rc or .21-pre

Regards,
-- 
  Steffen Persvold   |       Scali AS      
 mailto:sp@scali.com |  http://www.scali.com
Tel: (+47) 2262 8950 |   Olaf Helsets vei 6
Fax: (+47) 2262 8951 |   N0621 Oslo, NORWAY


[-- Attachment #2: Type: TEXT/PLAIN, Size: 398 bytes --]

--- linux-2.4.19-old/arch/i386/kernel/pci-dma.c.~1~	Wed Aug 14 15:06:49 2002
+++ linux-2.4.19/arch/i386/kernel/pci-dma.c	Wed Aug 14 15:08:29 2002
@@ -19,7 +19,7 @@
 	void *ret;
 	int gfp = GFP_ATOMIC;
 
-	if (hwdev == NULL || hwdev->dma_mask != 0xffffffff)
+	if (hwdev == NULL || hwdev->dma_mask < 0xffffffff)
 		gfp |= GFP_DMA;
 	ret = (void *)__get_free_pages(gfp, get_order(size));
 

[REPOST][PATCH] Fixup pci_alloc_consistent with 64bit DMA masks on i386

[Steffen Persvold]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 668 bytes --]


On Mon, 11 Nov 2002, Steffen Persvold wrote:

> Hi Marcelo,
> 
> I posted this small one-liner to Alan Cox (and to the lkml) in August but 
> it doesn't seem to have gotten into the mainline yet (I think it is in -ac).
> 
> The issue is that PCI drivers which uses 64bit DMA masks (in order to do 
> DAC) is making unnecessary use of the DMA zone memory (the <16Meg region 
> on i386) when doing pci_alloc_consitent().
> 
> Hope this gets into the next -rc or .21-pre
> 
> Regards,
> 

-- 
  Steffen Persvold   |       Scali AS      
 mailto:sp@scali.com |  http://www.scali.com
Tel: (+47) 2262 8950 |   Olaf Helsets vei 6
Fax: (+47) 2262 8951 |   N0621 Oslo, NORWAY

[-- Attachment #2: Type: TEXT/PLAIN, Size: 398 bytes --]

--- linux-2.4.19-old/arch/i386/kernel/pci-dma.c.~1~	Wed Aug 14 15:06:49 2002
+++ linux-2.4.19/arch/i386/kernel/pci-dma.c	Wed Aug 14 15:08:29 2002
@@ -19,7 +19,7 @@
 	void *ret;
 	int gfp = GFP_ATOMIC;
 
-	if (hwdev == NULL || hwdev->dma_mask != 0xffffffff)
+	if (hwdev == NULL || hwdev->dma_mask < 0xffffffff)
 		gfp |= GFP_DMA;
 	ret = (void *)__get_free_pages(gfp, get_order(size));
 

Re: [REPOST][PATCH] Fixup pci_alloc_consistent with 64bit DMA masks on i386

[Alan Cox]

Its been in -ac for ages, its clearly a fix