* [PATCH] selftests: net: use LDLIBS instead of LDFLAGS to link against libnuma
@ 2017-06-28 11:19 Fathi Boudra
2017-06-28 14:19 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Fathi Boudra @ 2017-06-28 11:19 UTC (permalink / raw)
To: linux-kselftest, Shuah Khan; +Cc: linux-kernel, SeongJae Park, Fathi Boudra
reuseport_bpf_numa fails to build with undefined reference:
aarch64-linaro-linux-gcc
--sysroot=/build/tmp-rpb-glibc/sysroots/hikey -Wall
-Wl,--no-as-needed -O2 -g -I../../../../usr/include/ -Wl,-O1
-Wl,--hash-style=gnu -Wl,--as-needed -lnuma reuseport_bpf_numa.c
-o
/build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa
/tmp/ccfUuExT.o: In function `send_from_node':
/build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:138:
undefined reference to `numa_run_on_node'
/tmp/ccfUuExT.o: In function `main':
/build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:230:
undefined reference to `numa_available'
/build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:233:
undefined reference to `numa_max_node'
Use LDLIBS instead of LDFLAGS to properly link against libnuma.
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
tools/testing/selftests/net/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 35cbb4cba410..17c732a19c4c 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -3,7 +3,7 @@
CFLAGS = -Wall -Wl,--no-as-needed -O2 -g
CFLAGS += -I../../../../usr/include/
-reuseport_bpf_numa: LDFLAGS += -lnuma
+reuseport_bpf_numa: LDLIBS += -lnuma
TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh
TEST_GEN_FILES = socket
--
2.13.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: net: use LDLIBS instead of LDFLAGS to link against libnuma
2017-06-28 11:19 [PATCH] selftests: net: use LDLIBS instead of LDFLAGS to link against libnuma Fathi Boudra
@ 2017-06-28 14:19 ` Shuah Khan
2017-06-28 14:36 ` Fathi Boudra
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2017-06-28 14:19 UTC (permalink / raw)
To: Fathi Boudra, linux-kselftest; +Cc: linux-kernel, SeongJae Park, Shuah Khan
On 06/28/2017 05:19 AM, Fathi Boudra wrote:
> reuseport_bpf_numa fails to build with undefined reference:
>
> aarch64-linaro-linux-gcc
> --sysroot=/build/tmp-rpb-glibc/sysroots/hikey -Wall
> -Wl,--no-as-needed -O2 -g -I../../../../usr/include/ -Wl,-O1
> -Wl,--hash-style=gnu -Wl,--as-needed -lnuma reuseport_bpf_numa.c
> -o
> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa
> /tmp/ccfUuExT.o: In function `send_from_node':
> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:138:
> undefined reference to `numa_run_on_node'
> /tmp/ccfUuExT.o: In function `main':
> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:230:
> undefined reference to `numa_available'
> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:233:
> undefined reference to `numa_max_node'
>
> Use LDLIBS instead of LDFLAGS to properly link against libnuma.
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
Did you try this on linux-ksefltest next? It has the fix for this.
thanks,
-- Shuah
> ---
> tools/testing/selftests/net/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 35cbb4cba410..17c732a19c4c 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -3,7 +3,7 @@
> CFLAGS = -Wall -Wl,--no-as-needed -O2 -g
> CFLAGS += -I../../../../usr/include/
>
> -reuseport_bpf_numa: LDFLAGS += -lnuma
> +reuseport_bpf_numa: LDLIBS += -lnuma
>
> TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh
> TEST_GEN_FILES = socket
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: net: use LDLIBS instead of LDFLAGS to link against libnuma
2017-06-28 14:19 ` Shuah Khan
@ 2017-06-28 14:36 ` Fathi Boudra
2017-06-28 15:12 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Fathi Boudra @ 2017-06-28 14:36 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel, SeongJae Park
On 28 June 2017 at 17:19, Shuah Khan <shuah@kernel.org> wrote:
> On 06/28/2017 05:19 AM, Fathi Boudra wrote:
>> reuseport_bpf_numa fails to build with undefined reference:
>>
>> aarch64-linaro-linux-gcc
>> --sysroot=/build/tmp-rpb-glibc/sysroots/hikey -Wall
>> -Wl,--no-as-needed -O2 -g -I../../../../usr/include/ -Wl,-O1
>> -Wl,--hash-style=gnu -Wl,--as-needed -lnuma reuseport_bpf_numa.c
>> -o
>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa
>> /tmp/ccfUuExT.o: In function `send_from_node':
>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:138:
>> undefined reference to `numa_run_on_node'
>> /tmp/ccfUuExT.o: In function `main':
>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:230:
>> undefined reference to `numa_available'
>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:233:
>> undefined reference to `numa_max_node'
>>
>> Use LDLIBS instead of LDFLAGS to properly link against libnuma.
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>
> Did you try this on linux-ksefltest next? It has the fix for this.
yes, I tried linux-ksefltest next and can reproduce.
> thanks,
> -- Shuah
>> ---
>> tools/testing/selftests/net/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
>> index 35cbb4cba410..17c732a19c4c 100644
>> --- a/tools/testing/selftests/net/Makefile
>> +++ b/tools/testing/selftests/net/Makefile
>> @@ -3,7 +3,7 @@
>> CFLAGS = -Wall -Wl,--no-as-needed -O2 -g
>> CFLAGS += -I../../../../usr/include/
>>
>> -reuseport_bpf_numa: LDFLAGS += -lnuma
>> +reuseport_bpf_numa: LDLIBS += -lnuma
>>
>> TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh
>> TEST_GEN_FILES = socket
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests: net: use LDLIBS instead of LDFLAGS to link against libnuma
2017-06-28 14:36 ` Fathi Boudra
@ 2017-06-28 15:12 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2017-06-28 15:12 UTC (permalink / raw)
To: Fathi Boudra; +Cc: linux-kselftest, linux-kernel, SeongJae Park, Shuah Khan
On 06/28/2017 08:36 AM, Fathi Boudra wrote:
> On 28 June 2017 at 17:19, Shuah Khan <shuah@kernel.org> wrote:
>> On 06/28/2017 05:19 AM, Fathi Boudra wrote:
>>> reuseport_bpf_numa fails to build with undefined reference:
>>>
>>> aarch64-linaro-linux-gcc
>>> --sysroot=/build/tmp-rpb-glibc/sysroots/hikey -Wall
>>> -Wl,--no-as-needed -O2 -g -I../../../../usr/include/ -Wl,-O1
>>> -Wl,--hash-style=gnu -Wl,--as-needed -lnuma reuseport_bpf_numa.c
>>> -o
>>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa
>>> /tmp/ccfUuExT.o: In function `send_from_node':
>>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:138:
>>> undefined reference to `numa_run_on_node'
>>> /tmp/ccfUuExT.o: In function `main':
>>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:230:
>>> undefined reference to `numa_available'
>>> /build/tmp-rpb-glibc/work/hikey-linaro-linux/kselftests/4.12-r0/linux-4.12-rc7/tools/testing/selftests/net/reuseport_bpf_numa.c:233:
>>> undefined reference to `numa_max_node'
>>>
>>> Use LDLIBS instead of LDFLAGS to properly link against libnuma.
>>>
>>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>>
>> Did you try this on linux-ksefltest next? It has the fix for this.
>
> yes, I tried linux-ksefltest next and can reproduce.
My question is whether this fix is on top of linux-kselftest next.
>
>> thanks,
>> -- Shuah
>>> ---
>>> tools/testing/selftests/net/Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
>>> index 35cbb4cba410..17c732a19c4c 100644
>>> --- a/tools/testing/selftests/net/Makefile
>>> +++ b/tools/testing/selftests/net/Makefile
>>> @@ -3,7 +3,7 @@
>>> CFLAGS = -Wall -Wl,--no-as-needed -O2 -g
>>> CFLAGS += -I../../../../usr/include/
>>>
>>> -reuseport_bpf_numa: LDFLAGS += -lnuma
>>> +reuseport_bpf_numa: LDLIBS += -lnum
>>>
>>> TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh
>>> TEST_GEN_FILES = socket
>
Please redo the patch on top of
SeongJae Park's fix
selftest/net/Makefile: Specify output with $(OUTPUT)
btw - with the the above fix, I don't see any failures on x86_64.
I am curious why it fails in cross-build? Could you figure out if
your cross-build environment is good.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-28 15:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-28 11:19 [PATCH] selftests: net: use LDLIBS instead of LDFLAGS to link against libnuma Fathi Boudra
2017-06-28 14:19 ` Shuah Khan
2017-06-28 14:36 ` Fathi Boudra
2017-06-28 15:12 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®