mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC
@ 2024-10-26 10:58 Konrad Dybcio
  2024-10-26 15:35 ` Dmitry Baryshkov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Konrad Dybcio @ 2024-10-26 10:58 UTC (permalink / raw)
  To: Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: Marijn Suijten, linux-arm-msm, linux-clk, linux-kernel,
	Konrad Dybcio, Vladimir Zapolskiy

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
required, as the GCC driver defines and instantiates a bunch of GDSCs.

Add the missing dependency.

Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Closes: https://lore.kernel.org/linux-arm-msm/ab85f2ae-6c97-4fbb-a15b-31cc9e1f77fc@linaro.org/
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/clk/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 953589e07c593fd49fab21c7cfcf466d33f99a27..c298d8e6700f6293f62269e5cc4ef518afc97a7a 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -1042,6 +1042,7 @@ config SM_GCC_7150
 config SM_GCC_8150
 	tristate "SM8150 Global Clock Controller"
 	depends on ARM64 || COMPILE_TEST
+	select QCOM_GDSC
 	help
 	  Support for the global clock controller on SM8150 devices.
 	  Say Y if you want to use peripheral devices such as UART,

---
base-commit: a39230ecf6b3057f5897bc4744a790070cfbe7a8
change-id: 20241026-topic-8150gcc_kconfig-0abc1f6ac9e8

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC
  2024-10-26 10:58 [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC Konrad Dybcio
@ 2024-10-26 15:35 ` Dmitry Baryshkov
  2024-10-27  0:22 ` Vladimir Zapolskiy
  2024-12-27  4:15 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-10-26 15:35 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Michael Turquette, Stephen Boyd, Marijn Suijten,
	linux-arm-msm, linux-clk, linux-kernel, Konrad Dybcio,
	Vladimir Zapolskiy

On Sat, Oct 26, 2024 at 12:58:13PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
> required, as the GCC driver defines and instantiates a bunch of GDSCs.
> 
> Add the missing dependency.
> 
> Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> Closes: https://lore.kernel.org/linux-arm-msm/ab85f2ae-6c97-4fbb-a15b-31cc9e1f77fc@linaro.org/
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC
  2024-10-26 10:58 [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC Konrad Dybcio
  2024-10-26 15:35 ` Dmitry Baryshkov
@ 2024-10-27  0:22 ` Vladimir Zapolskiy
  2024-12-27  4:15 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2024-10-27  0:22 UTC (permalink / raw)
  To: Konrad Dybcio, Bjorn Andersson, Michael Turquette, Stephen Boyd
  Cc: Marijn Suijten, linux-arm-msm, linux-clk, linux-kernel,
	Konrad Dybcio, Vladimir Zapolskiy

On 10/26/24 13:58, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
> required, as the GCC driver defines and instantiates a bunch of GDSCs.
> 
> Add the missing dependency.
> 
> Reported-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> Closes: https://lore.kernel.org/linux-arm-msm/ab85f2ae-6c97-4fbb-a15b-31cc9e1f77fc@linaro.org/
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>   drivers/clk/qcom/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 953589e07c593fd49fab21c7cfcf466d33f99a27..c298d8e6700f6293f62269e5cc4ef518afc97a7a 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -1042,6 +1042,7 @@ config SM_GCC_7150
>   config SM_GCC_8150
>   	tristate "SM8150 Global Clock Controller"
>   	depends on ARM64 || COMPILE_TEST
> +	select QCOM_GDSC
>   	help
>   	  Support for the global clock controller on SM8150 devices.
>   	  Say Y if you want to use peripheral devices such as UART,
> 

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>

--
Best wishes,
Vladimir

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC
  2024-10-26 10:58 [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC Konrad Dybcio
  2024-10-26 15:35 ` Dmitry Baryshkov
  2024-10-27  0:22 ` Vladimir Zapolskiy
@ 2024-12-27  4:15 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2024-12-27  4:15 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Konrad Dybcio
  Cc: Marijn Suijten, linux-arm-msm, linux-clk, linux-kernel,
	Konrad Dybcio, Vladimir Zapolskiy


On Sat, 26 Oct 2024 12:58:13 +0200, Konrad Dybcio wrote:
> Like all other non-ancient Qualcomm clock drivers, QCOM_GDSC is
> required, as the GCC driver defines and instantiates a bunch of GDSCs.
> 
> Add the missing dependency.
> 
> 

Applied, thanks!

[1/1] clk: qcom: Make GCC_8150 depend on QCOM_GDSC
      commit: 1474149c4209943b37a2c01b82f07ba39465e5fe

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-27  4:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-26 10:58 [PATCH] clk: qcom: Make GCC_8150 depend on QCOM_GDSC Konrad Dybcio
2024-10-26 15:35 ` Dmitry Baryshkov
2024-10-27  0:22 ` Vladimir Zapolskiy
2024-12-27  4:15 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®