* [PATCH] fs/jfs: Fix missing error code in lmLogInit()
@ 2021-06-01 11:07 Jiapeng Chong
2021-06-01 15:30 ` Dave Kleikamp
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-06-01 11:07 UTC (permalink / raw)
To: shaggy; +Cc: jfs-discussion, linux-kernel, Jiapeng Chong
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'rc.
Eliminate the follow smatch warning:
fs/jfs/jfs_logmgr.c:1327 lmLogInit() warn: missing error code 'rc'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/jfs/jfs_logmgr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 9330eff21..78fd136 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -1324,6 +1324,7 @@ int lmLogInit(struct jfs_log * log)
} else {
if (!uuid_equal(&logsuper->uuid, &log->uuid)) {
jfs_warn("wrong uuid on JFS log device");
+ rc = -EINVAL;
goto errout20;
}
log->size = le32_to_cpu(logsuper->size);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/jfs: Fix missing error code in lmLogInit()
2021-06-01 11:07 [PATCH] fs/jfs: Fix missing error code in lmLogInit() Jiapeng Chong
@ 2021-06-01 15:30 ` Dave Kleikamp
0 siblings, 0 replies; 2+ messages in thread
From: Dave Kleikamp @ 2021-06-01 15:30 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: jfs-discussion, linux-kernel
Good catch. I'll push this in the next merge window.
Thanks,
Shaggy
On 6/1/21 6:07 AM, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'rc.
>
> Eliminate the follow smatch warning:
>
> fs/jfs/jfs_logmgr.c:1327 lmLogInit() warn: missing error code 'rc'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/jfs/jfs_logmgr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 9330eff21..78fd136 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1324,6 +1324,7 @@ int lmLogInit(struct jfs_log * log)
> } else {
> if (!uuid_equal(&logsuper->uuid, &log->uuid)) {
> jfs_warn("wrong uuid on JFS log device");
> + rc = -EINVAL;
> goto errout20;
> }
> log->size = le32_to_cpu(logsuper->size);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-01 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 11:07 [PATCH] fs/jfs: Fix missing error code in lmLogInit() Jiapeng Chong
2021-06-01 15:30 ` Dave Kleikamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®