From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
charles.garcia-tobin@arm.com, linaro-dev@lists.linaro.org,
francescolavra.fl@gmail.com, toddpoynor@google.com
Subject: Re: [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr"
Date: Fri, 22 Feb 2013 03:33:56 +0100 [thread overview]
Message-ID: <10415300.xy5iOWqAMD@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohponQ0MVwbTpM-6MasewMQ7MWcL-3nFjf2d7DpAZbWKsNqw@mail.gmail.com>
On Friday, February 22, 2013 07:47:44 AM Viresh Kumar wrote:
> On 22 February 2013 05:15, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Why did you change all of the lines of this macro instead of changing just the
> > one line you needed to change?
>
> I didn't like the indentation used within the macro. So did it.
In general, things like that are for separate cleanup patches. If you mix
functional changes with cleanups, poeple get confused and it's difficult to see
what's needed and what's "optional".
I know it's tempting to fix stuff like that along with doing functional
changes and I do that sometimes. Not very often, though, and with care.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-02-22 2:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 7:49 [PATCH V2 0/4] CPUFreq: Implement per policy instances of governors Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 1/4] cpufreq: Add per policy governor-init/exit infrastructure Viresh Kumar
2013-02-21 23:35 ` Rafael J. Wysocki
2013-02-22 2:08 ` Viresh Kumar
2013-02-22 2:21 ` Rafael J. Wysocki
2013-02-22 2:19 ` Viresh Kumar
2013-02-22 2:31 ` Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 2/4] cpufreq: governor: Implement per policy instances of governors Viresh Kumar
2013-02-22 2:23 ` Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 3/4] cpufreq: Add Kconfig option to enable/disable have_multiple_policies Viresh Kumar
2013-02-21 23:53 ` Rafael J. Wysocki
2013-02-22 2:14 ` Viresh Kumar
2013-02-22 2:29 ` Rafael J. Wysocki
2013-02-22 2:44 ` Viresh Kumar
2013-02-11 7:50 ` [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr" Viresh Kumar
2013-02-21 23:45 ` Rafael J. Wysocki
2013-02-22 2:17 ` Viresh Kumar
2013-02-22 2:33 ` Rafael J. Wysocki [this message]
2013-02-22 2:32 ` Viresh Kumar
2013-02-22 2:46 ` [PATCH V2 0/4] CPUFreq: Implement per policy instances of governors Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10415300.xy5iOWqAMD@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=francescolavra.fl@gmail.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robin.randhawa@arm.com \
--cc=toddpoynor@google.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®