mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] 2.5.64 multicast: find interface correctly
@ 2003-03-08 23:49 Ted Phelps
  2003-03-09  0:02 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Ted Phelps @ 2003-03-08 23:49 UTC (permalink / raw)
  To: linux-kernel


Joining a multicast group (IP_ADD_MEMBERSHIP) with the imr_interface
set to INADDR_ANY binds to the loopback interface.  This differs from
the 2.4 behavior and appears to be because ip_mc_find_dev() calls
ip_route_output_key() with the interface address (0.0.0.0) rather than
the multicast address (which 2.4 kernels use).  The following patch
reverts to the linux-2.4 behavior.

Thanks,
-Ted

---8<---

--- linux-2.5.63/net/ipv4/igmp.c	2003-02-26 22:28:36.000000000 +0000
+++ linux-2.5.64/net/ipv4/igmp.c	2003-03-08 22:52:38.000000000 +0000
@@ -618,6 +618,7 @@
 		__dev_put(dev);
 	}
 
+	fl.nl_u.ip4_u.daddr = imr->imr_multiaddr.s_addr;
 	if (!dev && !ip_route_output_key(&rt, &fl)) {
 		dev = rt->u.dst.dev;
 		ip_rt_put(rt);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] 2.5.64 multicast: find interface correctly
  2003-03-08 23:49 [PATCH] 2.5.64 multicast: find interface correctly Ted Phelps
@ 2003-03-09  0:02 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2003-03-09  0:02 UTC (permalink / raw)
  To: Ted Phelps; +Cc: linux-kernel

James Morris posted a fix for this just the other day,
and it has been integrated into 2.5.x already.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-03-08 23:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-08 23:49 [PATCH] 2.5.64 multicast: find interface correctly Ted Phelps
2003-03-09  0:02 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®