From: Mark Haverkamp <markh@osdl.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: dougg@torque.net, Christoffer Hall-Frederiksen <hall@jiffies.dk>,
linux-scsi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux aacraid devel <linux-aacraid-devel@dell.com>
Subject: Re: Problem with aacraid driver in 2.5.63-bk-latest
Date: 13 Mar 2003 07:42:13 -0800 [thread overview]
Message-ID: <1047570132.30105.7.camel@markh1.pdx.osdl.net> (raw)
In-Reply-To: <1047517604.23902.39.camel@irongate.swansea.linux.org.uk>
On Wed, 2003-03-12 at 17:06, Alan Cox wrote:
> On Wed, 2003-03-12 at 23:55, Douglas Gilbert wrote:
> > /*
> > * Limit max queue depth on a single lun to 256 for now. Remember,
> > * we allocate a struct scsi_command for each of these and keep it
> > * around forever. Too deep of a depth just wastes memory.
> > */
> > if(tags > 256)
> > return;
> > ....
>
> I can see the memory consideration. However the thing can really handle big
> queues well. Possibly we should be setting the queue to 512 / somefunction(volumes)
> though to avoid the worst case overcommit here
>
Does the cmd_per_lun element of the Scsi_Host_Template structure serve
more than one purpose? In scsi_alloc_sdev it is passed into
scsi_adjust_queue_depth. In the aacraid case this is 512. Later the
aacraid driver (in aac_slave_configure) sets the queue depth to either
128 for tagged or 1 if not.
Mark.
--
Mark Haverkamp <markh@osdl.org>
next prev parent reply other threads:[~2003-03-13 15:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030228133037.GB7473@jiffies.dk>
2003-03-12 23:06 ` Mark Haverkamp
2003-03-13 0:18 ` Alan Cox
2003-03-12 23:55 ` Douglas Gilbert
2003-03-13 1:06 ` Alan Cox
2003-03-13 0:50 ` Mike Anderson
2003-03-13 23:13 ` Mark Haverkamp
2003-03-14 7:05 ` Denis Vlasenko
2003-03-14 10:18 ` Mike Anderson
2003-03-13 1:31 ` Douglas Gilbert
2003-03-13 23:27 ` Doug Ledford
2003-03-13 15:42 ` Mark Haverkamp [this message]
2003-03-13 23:17 ` Doug Ledford
2003-03-13 23:22 ` Mark Haverkamp
2003-03-13 23:25 ` Doug Ledford
2003-03-14 14:57 ` Alan Cox
2003-03-14 15:34 ` Mark Haverkamp
2003-03-14 16:48 ` Alan Cox
2003-03-03 10:05 Christoffer Hall-Frederiksen
2003-03-03 13:40 ` Alan Cox
2003-03-03 14:46 ` Christoffer Hall-Frederiksen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1047570132.30105.7.camel@markh1.pdx.osdl.net \
--to=markh@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dougg@torque.net \
--cc=hall@jiffies.dk \
--cc=linux-aacraid-devel@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®