mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Randy.Dunlap" <randy.dunlap@verizon.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@transmeta.com>,
	leo@netlabs.net
Subject: Re: [PATCH] reduce stack in cdrom/optcd.c
Date: 22 Mar 2003 20:43:19 +0000	[thread overview]
Message-ID: <1048365798.9221.35.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <3E7C0808.75B95FB7@verizon.net>

On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
> Hi,
> 
> This reduces stack usage in drivers/cdrom/optcd.c by
> dynamically allocating a large (> 2 KB) buffer.
> 
> Patch is to 2.5.65.  Please apply.

This loosk broken. You are using GFP_KERNEL memory allocations on the
read path of a block device. What happens if the allocation fails 
because we need memory

Surely that buffer needs to be allocated once at open and freed on close
?


  reply	other threads:[~2003-03-22 19:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-22  6:51 Randy.Dunlap
2003-03-22 20:43 ` Alan Cox [this message]
2003-03-22 20:19   ` Arjan van de Ven
2003-03-25 18:29     ` Jens Axboe
2003-03-25 18:43       ` Randy.Dunlap
2003-03-26 20:12 Randy.Dunlap
2003-03-27  6:54 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1048365798.9221.35.camel@irongate.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=leo@netlabs.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@verizon.net \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®