Re: [PATCH] reduce stack in cdrom/optcd.c

["Randy.Dunlap" <rddunlap@osdl.org>]

On Tue, 25 Mar 2003 19:29:16 +0100 Jens Axboe <axboe@suse.de> wrote:

| On Sat, Mar 22 2003, Arjan van de Ven wrote:
| > On Sat, 2003-03-22 at 21:43, Alan Cox wrote:
| > > On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
| > > > Hi,
| > > > 
| > > > This reduces stack usage in drivers/cdrom/optcd.c by
| > > > dynamically allocating a large (> 2 KB) buffer.
| > > > 
| > > > Patch is to 2.5.65.  Please apply.
| > > 
| > > This loosk broken. You are using GFP_KERNEL memory allocations on the
| > > read path of a block device. What happens if the allocation fails 
| > > because we need memory
| > 
| > it's unlikely that you have your swap on the cdrom ;)
| 
| your swap device could still be plugged behind your cdrom.

I plan to change it as Alan suggested.  Will do.

--
~Randy