mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: dan carpenter <d_carpenter@sbcglobal.net>
Cc: Brian Gerst <bgerst@didntduck.org>,
	Thomas Molina <tmolina@cox.net>,
	jsimmons@infradead.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: sleeping function call in 2.5.65-bk
Date: 23 Mar 2003 20:41:31 +0000	[thread overview]
Message-ID: <1048452091.10727.71.camel@irongate.swansea.linux.org.uk> (raw)
In-Reply-To: <200303231905.h2NJ57OU665784@pimout3-ext.prodigy.net>

On Sun, 2003-03-23 at 01:44, dan carpenter wrote:
> On Sunday 23 March 2003 05:30 pm, Brian Gerst wrote:
> >
> > The fbcon driver is calling kmalloc in interrupt context without
> > GFP_ATOMIC.
> 
> Good call.  This is compile tested only.

It was wrong before its now even more wrong. Suppose the allocation
fails. Previously that was wildly improbable (but crashed) now its
likely (and crashes0

This code has bigger issues


      parent reply	other threads:[~2003-03-23 19:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-23 16:05 Thomas Molina
2003-03-23 16:30 ` Brian Gerst
2003-03-23  1:44   ` dan carpenter
2003-03-23 20:19     ` James Simmons
2003-03-23 20:41     ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1048452091.10727.71.camel@irongate.swansea.linux.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bgerst@didntduck.org \
    --cc=d_carpenter@sbcglobal.net \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tmolina@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®