From: dan carpenter <d_carpenter@sbcglobal.net>
To: Brian Gerst <bgerst@didntduck.org>,
Thomas Molina <tmolina@cox.net>, <jsimmons@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: sleeping function call in 2.5.65-bk
Date: Sun, 23 Mar 2003 02:44:25 +0100 [thread overview]
Message-ID: <200303231905.h2NJ57OU665784@pimout3-ext.prodigy.net> (raw)
In-Reply-To: <3E7DE12C.2020301@quark.didntduck.org>
On Sunday 23 March 2003 05:30 pm, Brian Gerst wrote:
>
> The fbcon driver is calling kmalloc in interrupt context without
> GFP_ATOMIC.
Good call. This is compile tested only.
regards,
dan carpenter
--- drivers/video/console/fbcon.c.orig 2003-03-23 02:39:23.000000000 +0100
+++ drivers/video/console/fbcon.c 2003-03-23 02:40:39.000000000 +0100
@@ -985,8 +985,8 @@
size = ((width + 7) >> 3) * height;
- data = kmalloc(size, GFP_KERNEL);
- mask = kmalloc(size, GFP_KERNEL);
+ data = kmalloc(size, GFP_ATOMIC);
+ mask = kmalloc(size, GFP_ATOMIC);
if (cursor->set & FB_CUR_SETSIZE) {
memset(data, 0xff, size);
next prev parent reply other threads:[~2003-03-23 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-23 16:05 Thomas Molina
2003-03-23 16:30 ` Brian Gerst
2003-03-23 1:44 ` dan carpenter [this message]
2003-03-23 20:19 ` James Simmons
2003-03-23 20:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303231905.h2NJ57OU665784@pimout3-ext.prodigy.net \
--to=d_carpenter@sbcglobal.net \
--cc=bgerst@didntduck.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tmolina@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®