From: Andi Kleen <ak@suse.de>
To: davej@codemonkey.org.uk
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [x86-64] Add missing tlb flush after change_page_attr
Date: 24 Mar 2003 18:32:16 +0100 [thread overview]
Message-ID: <1048527139.12339.109.camel@averell> (raw)
In-Reply-To: <200303241641.h2OGfw35008208@deviant.impure.org.uk>
On Mon, 2003-03-24 at 17:41, davej@codemonkey.org.uk wrote:
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/arch/x86_64/kernel/pci-gart.c linux-2.5/arch/x86_64/kernel/pci-gart.c
> --- bk-linus/arch/x86_64/kernel/pci-gart.c 2003-03-08 09:56:51.000000000 +0000
> +++ linux-2.5/arch/x86_64/kernel/pci-gart.c 2003-03-18 21:19:53.000000000 +0000
> @@ -419,6 +419,7 @@ static __init int init_k8_gatt(agp_kern_
> panic("Cannot allocate GATT table");
> memset(gatt, 0, gatt_size);
> change_page_attr(virt_to_page(gatt), gatt_size/PAGE_SIZE, PAGE_KERNEL_NOCACHE);
> + global_flush_tlb();
> agp_gatt_table = gatt;
>
> for_all_nb(dev) {
No it needs to be completely removed. the pci aperture is supposed to be
cachable (unlike the AGP aperture) That's still a trace of an earlier
design.
-Andi
next prev parent reply other threads:[~2003-03-24 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-24 16:41 davej
2003-03-24 17:32 ` Andi Kleen [this message]
2003-03-25 0:25 ` [PATCH][x86-64] make the pci aperture cachable Thomas Schlichter
2003-03-25 1:46 ` Andi Kleen
2003-03-24 20:08 ` [x86-64] Add missing tlb flush after change_page_attr Thomas Schlichter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1048527139.12339.109.camel@averell \
--to=ak@suse.de \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®