[PATCH][x86-64] make the pci aperture cachable

[Thomas Schlichter <schlicht@uni-mannheim.de>]

[-- Attachment #1.1: body text --]
[-- Type: text/plain, Size: 1054 bytes --]

Am Montag, 24. März 2003 18:32 schrieb Andi Kleen:
> On Mon, 2003-03-24 at 17:41, davej@codemonkey.org.uk wrote:
> > diff -urpN --exclude-from=/home/davej/.exclude 
bk-linus/arch/x86_64/kernel/pci-gart.c 
linux-2.5/arch/x86_64/kernel/pci-gart.c
> > --- bk-linus/arch/x86_64/kernel/pci-gart.c	2003-03-08 09:56:51.000000000 
+0000
> > +++ linux-2.5/arch/x86_64/kernel/pci-gart.c	2003-03-18 21:19:53.000000000 
+0000
> > @@ -419,6 +419,7 @@ static __init int init_k8_gatt(agp_kern_
> >  		panic("Cannot allocate GATT table"); 
> >  	memset(gatt, 0, gatt_size); 
> >  	change_page_attr(virt_to_page(gatt), gatt_size/PAGE_SIZE, 
PAGE_KERNEL_NOCACHE);
> > +	global_flush_tlb();
> >  	agp_gatt_table = gatt;
> >  	
> >  	for_all_nb(dev) { 
> 
> No it needs to be completely removed. the pci aperture is supposed to be
> cachable (unlike the AGP aperture) That's still a trace of an earlier
> design.
> 
> -Andi

As this patch has been applied anyway here is a patch to make the pci aperture 
cachable for 2.5.66.

  Thomas Schlichter

[-- Attachment #1.2: pci-gart.patch --]
[-- Type: text/x-diff, Size: 592 bytes --]

--- linux-2.5.66/arch/x86_64/kernel/pci-gart.c.old	Tue Mar 25 01:09:51 2003
+++ linux-2.5.66/arch/x86_64/kernel/pci-gart.c	Tue Mar 25 01:16:28 2003
@@ -418,8 +418,6 @@
 	if (!gatt) 
 		panic("Cannot allocate GATT table"); 
 	memset(gatt, 0, gatt_size); 
-	change_page_attr(virt_to_page(gatt), gatt_size/PAGE_SIZE, PAGE_KERNEL_NOCACHE);
-	global_flush_tlb();
 	agp_gatt_table = gatt;
 	
 	for_all_nb(dev) { 
@@ -438,8 +436,6 @@
 	}
 	flush_gart(); 
 	
-	global_flush_tlb();
-		
 	printk("PCI-DMA: aperture base @ %x size %u KB\n", aper_base, aper_size>>10); 
 	return 0;
 

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]