Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()

Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()

[Geert Uytterhoeven]

On Sun, 20 Apr 2003, Linux Kernel Mailing List wrote:
> ChangeSet 1.1124.1.25, 2003/04/20 14:28:32-07:00, akpm@digeo.com
> 
> 	[PATCH] use __GFP_REPEAT in pmd_alloc_one()
> 	
> 	Convert all pmd_alloc_one() implementations to use __GFP_REPEAT

If this change was bogus (cfr. Davem's checkin):

> diff -Nru a/arch/sparc/mm/sun4c.c b/arch/sparc/mm/sun4c.c
> --- a/arch/sparc/mm/sun4c.c	Sun Apr 20 15:24:17 2003
> +++ b/arch/sparc/mm/sun4c.c	Sun Apr 20 15:24:17 2003
> @@ -2194,7 +2194,7 @@
>  	BTFIXUPSET_CALL(pte_alloc_one_kernel, sun4c_pte_alloc_one_kernel, BTFIXUPCALL_NORM);
>  	BTFIXUPSET_CALL(pte_alloc_one, sun4c_pte_alloc_one, BTFIXUPCALL_NORM);
>  	BTFIXUPSET_CALL(free_pmd_fast, sun4c_free_pmd_fast, BTFIXUPCALL_NOP);
> -	BTFIXUPSET_CALL(pmd_alloc_one, sun4c_pmd_alloc_one, BTFIXUPCALL_RETO0);
> +	BTFIXUPSET_CALL(pmd_alloc_one, sun4c_lpmd_alloc_one, BTFIXUPCALL_RETO0);
>  	BTFIXUPSET_CALL(free_pgd_fast, sun4c_free_pgd_fast, BTFIXUPCALL_NORM);
>  	BTFIXUPSET_CALL(get_pgd_fast, sun4c_get_pgd_fast, BTFIXUPCALL_NORM);

Then this one is bogus, too:

> diff -Nru a/include/asm-m68k/sun3_pgalloc.h b/include/asm-m68k/sun3_pgalloc.h
> --- a/include/asm-m68k/sun3_pgalloc.h	Sun Apr 20 15:24:17 2003
> +++ b/include/asm-m68k/sun3_pgalloc.h	Sun Apr 20 15:24:17 2003
> @@ -18,7 +18,7 @@
>  
>  extern const char bad_pmd_string[];
>  
> -#define pmd_alloc_one(mm,address)       ({ BUG(); ((pmd_t *)2); })
> +#define lpmd_alloc_one(mm,address)       ({ BUG(); ((pmd_t *)2); })
>  
>  

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()

[David S. Miller]

On Tue, 2003-04-22 at 02:46, Geert Uytterhoeven wrote:
> If this change was bogus (cfr. Davem's checkin):
...
> Then this one is bogus, too:

I don't think so, I believe Andrew was just trying to trap cases he
didn't understand.

-- 
David S. Miller <davem@redhat.com>

Re: [PATCH] use __GFP_REPEAT in pmd_alloc_one()

[Andrew Morton]

"David S. Miller" <davem@redhat.com> wrote:
>
> On Tue, 2003-04-22 at 02:46, Geert Uytterhoeven wrote:
> > If this change was bogus (cfr. Davem's checkin):
> ...
> > Then this one is bogus, too:
> 
> I don't think so, I believe Andrew was just trying to trap cases he
> didn't understand.

No, it was just a flip of the singers.  I typed `l' instead of control-l.
It was late.  Sorry 'bout that.