From: "David S. Miller" <davem@redhat.com>
To: davidm@hpl.hp.com
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: qla1280 mem-mapped I/O fix
Date: 10 May 2003 04:30:11 -0700 [thread overview]
Message-ID: <1052566211.22636.1.camel@rth.ninka.net> (raw)
In-Reply-To: <200305100951.h4A9pSAD012127@napali.hpl.hp.com>
On Sat, 2003-05-10 at 02:51, David Mosberger wrote:
> With the fix in the second hunk, I don't see any reason not to turn on
> MEMORY_MAPPED_IO in qla1280. It seems to work fine on my machine
> with this controller (ia64 Big Sur).
David, you absolute MAY NOT pass this:
> - pci_read_config_word (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);
> + pci_read_config_dword (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);
into ioremap() which is exactly what this driver is doing.
One must use the PCI device struct resource values.
--
David S. Miller <davem@redhat.com>
next prev parent reply other threads:[~2003-05-10 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-10 9:51 David Mosberger
2003-05-10 10:15 ` Arjan van de Ven
2003-05-10 10:25 ` David Mosberger
2003-05-15 15:52 ` Jes Sorensen
2003-05-16 4:06 ` Andrey Panin
2003-05-10 11:30 ` David S. Miller [this message]
2003-05-10 11:34 ` David Mosberger
2003-05-10 12:12 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1052566211.22636.1.camel@rth.ninka.net \
--to=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®