From: David Mosberger <davidm@napali.hpl.hp.com>
To: arjanv@redhat.com
Cc: davidm@hpl.hp.com, torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: qla1280 mem-mapped I/O fix
Date: Sat, 10 May 2003 03:25:35 -0700 [thread overview]
Message-ID: <16060.54175.634093.943752@napali.hpl.hp.com> (raw)
In-Reply-To: <1052561708.1367.0.camel@laptop.fenrus.com>
>>>>> On 10 May 2003 12:15:08 +0200, Arjan van de Ven <arjanv@redhat.com> said:
>> @@ -2634,7 +2634,7 @@
>> /*
>> * Get memory mapped I/O address.
>> */
>> - pci_read_config_word (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);
>> + pci_read_config_dword (ha->pdev, PCI_BASE_ADDRESS_1, &mmapbase);
>> mmapbase &= PCI_BASE_ADDRESS_MEM_MASK;
Arjan> shouldn't this be pci_resource_start() ?
Probably should be. I wanted a minimal fix, because if you start
cleaning up qla1280, it won't stop there... ;-(
--david
next prev parent reply other threads:[~2003-05-10 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-10 9:51 David Mosberger
2003-05-10 10:15 ` Arjan van de Ven
2003-05-10 10:25 ` David Mosberger [this message]
2003-05-15 15:52 ` Jes Sorensen
2003-05-16 4:06 ` Andrey Panin
2003-05-10 11:30 ` David S. Miller
2003-05-10 11:34 ` David Mosberger
2003-05-10 12:12 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16060.54175.634093.943752@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=arjanv@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®