From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] And yet more PCI fixes for 2.5.70
Date: 11 Jun 2003 18:19:49 +0100 [thread overview]
Message-ID: <1055351984.2419.23.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030611163837.GA24951@kroah.com>
On Mer, 2003-06-11 at 17:38, Greg KH wrote:
> So that leaves only this file. Jeff Garzik and I talked about removing
> pci_present() as it's not needed, and I think for this one case we can
> live without it. Do you want me to make the pci_present() macro earlier
> in this file, so it's readable again? I don't want to put it back into
> pci.h.
I still think it belongs in pci.h. Its an API and the API makes sense. The
implementation may change in time so it belongs in pci.h in one spot
next prev parent reply other threads:[~2003-06-11 17:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 0:11 [BK PATCH] " Greg KH
2003-06-11 0:11 ` [PATCH] " Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 12:37 ` Alan Cox
2003-06-11 12:47 ` Christoph Hellwig
2003-06-11 12:53 ` Dave Jones
2003-06-11 16:38 ` Greg KH
2003-06-11 17:19 ` Alan Cox [this message]
2003-06-11 17:46 ` Jeff Garzik
2003-06-11 19:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055351984.2419.23.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®