From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] And yet more PCI fixes for 2.5.70
Date: 11 Jun 2003 20:13:11 +0100 [thread overview]
Message-ID: <1055358790.2419.34.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030611174629.GC31051@gtf.org>
On Mer, 2003-06-11 at 18:46, Jeff Garzik wrote:
> Its an API that doesn't make sense.
Is this a PCI box is a sane thing to ask
> "Is a PCI bus present?" Further, the IDE code calculating system
> bus speed it should really be calling a PCI callback, not asking "Do
> I have a PCI bus?" and making a guess... a guess which seems wrong
> in several cases, including my Dual Athlon box w/ 100% 66 Mhz PCI bus.
Wrong. You misunderstand why this is done. We want to know for various
wackomtic old IDE devices and the key to knowing if its going to be
33Mhz is "does it have a PCI bus".
BTW if you want to be pedantic your "fix" is as broken as the original
since PCI root bridges can live on hotpluggable cards on a different
system bus 8)
prev parent reply other threads:[~2003-06-11 19:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 0:11 [BK PATCH] " Greg KH
2003-06-11 0:11 ` [PATCH] " Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 0:11 ` Greg KH
2003-06-11 12:37 ` Alan Cox
2003-06-11 12:47 ` Christoph Hellwig
2003-06-11 12:53 ` Dave Jones
2003-06-11 16:38 ` Greg KH
2003-06-11 17:19 ` Alan Cox
2003-06-11 17:46 ` Jeff Garzik
2003-06-11 19:13 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055358790.2419.34.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®