From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: walt <wa1ter@myrealbox.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.21-ac1
Date: 14 Jun 2003 18:59:44 +0100 [thread overview]
Message-ID: <1055613583.8281.23.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <3EEAF192.4050102@myrealbox.com>
On Sad, 2003-06-14 at 10:57, walt wrote:
> This is the offending line in serialmidi.c:
>
> if (tty->count > 1) {
> snd_printk(KERN_ERR "tty %s is already used", serial->sdev);
>
> The compilation will finish if I make this change:
>
> if (atomic_read(&(tty->count)) > 1) {
>
> Since I don't have a clue what I'm doing this is probably not the right fix :0)
> I suspect that changing the alsa code is starting at the wrong end of the
> problem anyway.
The tty code changed to atomic counters to fix a race. Your fix is
right.
next prev parent reply other threads:[~2003-06-14 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-14 14:30 Alan Cox
2003-06-14 9:57 ` walt
2003-06-14 17:59 ` Alan Cox [this message]
2003-06-14 16:01 ` Aschwin Marsman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055613583.8281.23.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=wa1ter@myrealbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®