Re: Linux 2.4.21-ac1

[walt <wa1ter@myrealbox.com>]

Alan Cox wrote:
> Linux 2.4.21-ac1

Hi Alan,

Starting two 'ac' versions ago (rc7, IIRC) I can't compile the alsa-driver package:

gcc -D__KERNEL__ -DMODULE=1 -I/var/tmp/portage/alsa-driver-0.9.2/work/alsa-driver-0.9.2/include  -I/usr/src/linux/include -O2 -mpreferred-stack-boundary=2 -march=athlon -DLINUX -Wall 
-Wstrict-prototypes -fomit-frame-pointer -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -DALSA_BUILD  -DKBUILD_BASENAME=serialmidi   -c -o serialmidi.o serialmidi.c
serialmidi.c: In function `open_tty':
serialmidi.c:158: invalid operands to binary >
make[1]: *** [serialmidi.o] Error 1

This problem is specific to the ac tree.  The vanilla kernel allows the alsa-
drivers to compile without problem.

This is the offending line in serialmidi.c:

	if (tty->count > 1) {
		snd_printk(KERN_ERR "tty %s is already used", serial->sdev);

The compilation will finish if I make this change:

	if (atomic_read(&(tty->count)) > 1) {

Since I don't have a clue what I'm doing this is probably not the right fix :0)
I suspect that changing the alsa code is starting at the wrong end of the
problem anyway.

Am I the only one seeing this?