mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* PATCH 2.4.21 fix: kswapd can fail starting
@ 2003-06-27 20:24 Walter Harms
  2003-06-27 22:56 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Walter Harms @ 2003-06-27 20:24 UTC (permalink / raw)
  To: linux-kernel

Hi list,
when i was looking for non checked returns of kernel_thread() i noticed
that vmscan.c never checks. This patch changes that. Note that
kswapd_init() can fail. I have no idea what to do then perhaps somebody
should take a look at that also ?

walter

--- mm/vmscan.c.org     2003-06-25 21:49:45.000000000 +0200
+++ mm/vmscan.c 2003-06-25 21:45:39.000000000 +0200
@@ -768,7 +768,8 @@
 {
        printk("Starting kswapd\n");
        swap_setup();
-       kernel_thread(kswapd, NULL, CLONE_FS | CLONE_FILES | CLONE_SIGNAL);
+       if (kernel_thread(kswapd, NULL, CLONE_FS | CLONE_FILES | CLONE_SIGNAL)<0)
+         return 1;
        return 0;
 }

-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH 2.4.21 fix: kswapd can fail starting
  2003-06-27 20:24 PATCH 2.4.21 fix: kswapd can fail starting Walter Harms
@ 2003-06-27 22:56 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2003-06-27 22:56 UTC (permalink / raw)
  To: Walter Harms; +Cc: Linux Kernel Mailing List

On Gwe, 2003-06-27 at 21:24, Walter Harms wrote:
> Hi list,
> when i was looking for non checked returns of kernel_thread() i noticed
> that vmscan.c never checks. This patch changes that. Note that
> kswapd_init() can fail. I have no idea what to do then perhaps somebody
> should take a look at that also ?

I suspect this one is at best a

BUG_ON(blah < 0)


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-06-27 22:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-27 20:24 PATCH 2.4.21 fix: kswapd can fail starting Walter Harms
2003-06-27 22:56 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®