* [PATCH 2.6.0-test4] wait.h: fix spin_lock_irqrestore typo
@ 2003-08-23 13:55 Vinay K Nallamothu
2003-08-23 22:18 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Vinay K Nallamothu @ 2003-08-23 13:55 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML
Hi Linus,
A small patch to fix a spin_lock typo in the macro add_wait_queue_cond
Vinay
--- linux-2.6.0-test4/include/linux/wait.h 2003-07-15 17:22:56.000000000 +0530
+++ linux-2.6.0-test4-nvk/include/linux/wait.h 2003-08-23 19:08:36.000000000 +0530
@@ -232,7 +232,7 @@
_raced = 1; \
__remove_wait_queue((q), (wait)); \
} \
- spin_lock_irqrestore(&(q)->lock, flags); \
+ spin_unlock_irqrestore(&(q)->lock, flags); \
_raced; \
})
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.0-test4] wait.h: fix spin_lock_irqrestore typo
2003-08-23 13:55 [PATCH 2.6.0-test4] wait.h: fix spin_lock_irqrestore typo Vinay K Nallamothu
@ 2003-08-23 22:18 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2003-08-23 22:18 UTC (permalink / raw)
To: Vinay K Nallamothu; +Cc: torvalds, linux-kernel
Vinay K Nallamothu <vinay-rc@naturesoft.net> wrote:
>
> A small patch to fix a spin_lock typo in the macro add_wait_queue_cond
>
> Vinay
>
> --- linux-2.6.0-test4/include/linux/wait.h 2003-07-15 17:22:56.000000000 +0530
> +++ linux-2.6.0-test4-nvk/include/linux/wait.h 2003-08-23 19:08:36.000000000 +0530
> @@ -232,7 +232,7 @@
> _raced = 1; \
> __remove_wait_queue((q), (wait)); \
> } \
> - spin_lock_irqrestore(&(q)->lock, flags); \
> + spin_unlock_irqrestore(&(q)->lock, flags); \
> _raced; \
> })
Well that's obviously had a lot of testing.
It has no callers; I'll just kill it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-08-23 22:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-23 13:55 [PATCH 2.6.0-test4] wait.h: fix spin_lock_irqrestore typo Vinay K Nallamothu
2003-08-23 22:18 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®