* Re: [PATCH] Firmware loading depends on hotplug support [not found] <200309011502.h81F2Mq6003467@hera.kernel.org> @ 2003-09-01 16:35 ` Tom Rini 2003-09-01 16:59 ` Marcel Holtmann 0 siblings, 1 reply; 2+ messages in thread From: Tom Rini @ 2003-09-01 16:35 UTC (permalink / raw) To: marcel, Kernel Mailing List On Fri, Aug 15, 2003 at 04:27:11PM +0000, marcel@holtmann.org wrote: > ChangeSet 1.1065.2.3, 2003/08/15 18:27:11+02:00, marcel@holtmann.org > > [PATCH] Firmware loading depends on hotplug support > > This patch makes the firmware loading support only selectable if the > hotplug support is also enabled. > > > # This patch includes the following deltas: > # ChangeSet 1.1065.2.2 -> 1.1065.2.3 > # lib/Config.in 1.4 -> 1.5 > # > > Config.in | 3 ++- > 1 files changed, 2 insertions(+), 1 deletion(-) > > > diff -Nru a/lib/Config.in b/lib/Config.in > --- a/lib/Config.in Mon Sep 1 08:02:24 2003 > +++ b/lib/Config.in Mon Sep 1 08:02:24 2003 > @@ -41,7 +41,8 @@ > fi > fi > > -if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then > +if [ "$CONFIG_EXPERIMENTAL" = "y" -a \ > + "$CONFIG_HOTPLUG" = "y" ]; then > tristate 'Hotplug firmware loading support (EXPERIMENTAL)' CONFIG_FW_LOADER > fi Is this really a good idea, given that USB devices may be hot-plugged, without CONFIG_HOTPLUG set (drivers are compiled in, for example) ? -- Tom Rini http://gate.crashing.org/~trini/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Firmware loading depends on hotplug support 2003-09-01 16:35 ` [PATCH] Firmware loading depends on hotplug support Tom Rini @ 2003-09-01 16:59 ` Marcel Holtmann 0 siblings, 0 replies; 2+ messages in thread From: Marcel Holtmann @ 2003-09-01 16:59 UTC (permalink / raw) To: Tom Rini; +Cc: Linux Kernel Mailing List Hi Tom, > > [PATCH] Firmware loading depends on hotplug support > > > > This patch makes the firmware loading support only selectable if the > > hotplug support is also enabled. > > > > > > # This patch includes the following deltas: > > # ChangeSet 1.1065.2.2 -> 1.1065.2.3 > > # lib/Config.in 1.4 -> 1.5 > > # > > > > Config.in | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletion(-) > > > > > > diff -Nru a/lib/Config.in b/lib/Config.in > > --- a/lib/Config.in Mon Sep 1 08:02:24 2003 > > +++ b/lib/Config.in Mon Sep 1 08:02:24 2003 > > @@ -41,7 +41,8 @@ > > fi > > fi > > > > -if [ "$CONFIG_EXPERIMENTAL" = "y" ]; then > > +if [ "$CONFIG_EXPERIMENTAL" = "y" -a \ > > + "$CONFIG_HOTPLUG" = "y" ]; then > > tristate 'Hotplug firmware loading support (EXPERIMENTAL)' CONFIG_FW_LOADER > > fi > > Is this really a good idea, given that USB devices may be hot-plugged, > without CONFIG_HOTPLUG set (drivers are compiled in, for example) ? this option is only provided for drivers outside the kernel. If a driver inside the kernel needs it, it is selected automaticly like the CRC32 routines. If you disable hotplug support the request_firmware() routine will return an error and this must be handled by the driver. Regards Marcel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-01 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <200309011502.h81F2Mq6003467@hera.kernel.org>
2003-09-01 16:35 ` [PATCH] Firmware loading depends on hotplug support Tom Rini
2003-09-01 16:59 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome